Update rubocop in / from 0.51.0 to 0.52.1 #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependencies[bot]](https://avatars.githubusercontent.com/in/2310?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies.io has updated
rubocop(a rubygems dependency in/) from "0.51.0" to "0.52.1".0.52.1
Bug fixes
Layout/AlignHashwhen using a hash including only a keyword splat. (wata727)Style/FormatStringTokento allow regexp token. (pocke)Layout/EmptyLinesAroundArgumentsoperating on blocks. (garettarrowood)Rails/HasManyOrHasOneDependentwhen usingclass_nameoption. (koic)Style/EvalWithLocationreporting bad line offset. (pocke)Metrics/LineLength:Maxfor--auto-gen-config. (jonas054)Rails/RedundantReceiverInWithOptionswhen including another receiver inwith_options. (wata727)Style/CommentedKeyword. (garettarrowood)Style/MixinUsagewhen using inside class or module. (koic)Layout/SpaceInsideReferenceBracketsandLayout/SpaceInsideArrayLiteralBracketsconfiguration conflicts. (garettarrowood)Style/AutoResourceCleanupshouldn't flagFile.open(...).close. (dpostorivo)loaded_pathin warning. (chrishulton)Rails/HasManyOrHasOneDependentwhen using a option ofhas_manyorhas_oneassociation. (koic)Rails/Presencewhen the else block is multiline. (wata727)Rails/InverseOfwhen includingthroughorpolymorphicoptions. (wata727)--auto-gen-configmight fail on invalid YAML. (bquorning)Style/HashSyntaxfrom stripping quotes off of symbols during autocorrection for ruby22+. (garettarrowood)Layout/RescueEnsureAlignmentin Ruby 2.5. (pocke)Rails/InverseOfwhen usingwith_options. (wata727)Style/BracesAroundHashParametersautocorrect. (flyerhzm).ruby-versionin parent directories. (ybiquitous)Changes
Style/ExtendSelfcop. (pocke)Layout/SpaceBeforeBlockBraces'sEnforcedStyleForEmptyBracesfromno_spacetospace. (garettarrowood)Correctorclasses and move allautocorrectmethods out of mixin Modules. (garettarrowood)0.52.0
New features
TargetRubyVersion2.5. (walf443)Layout/ClassStructurecop that checks whether definitions in a class are in the configured order. This cop is disabled by default. (jonatas)Rails/InverseOfchecks for association arguments that require setting theinverse_ofoption manually. (bdewater)Layout/SpaceInsideReferenceBracketscop. (garettarrowood)Layout/SpaceInsideArrayLiteralBracketscop. (garettarrowood)Style/TrailingBodyOnMethodDefinitioncop. (garettarrowood)Style/TrailingMethodEndStatmentcop. (garettarrowood)Style/StringHashKeyscop. (donjar)Style/RandomWithOffsetcop. (donjar)Lint/ShadowedArgumentcop and remove argument shadowing detection fromLint/UnusedBlockArgumentandLint/UnusedMethodArgument. (akhramov)Lint/MissingCopEnableDirectivecop. (tdeo)Rails/EnvironmentComparisoncop. (tdeo)AllowedCharsoption toStyle/AsciiCommentscop. (hedgesky)Style/EmptyBlockParameterandStyle/EmptyLambdaParametercops. (pocke)Gemspec/RequiredRubyVersioncop. (koic)Gemspec/RedundantAssignmentcop. (koic)unannotatedoption toStyle/FormatStringTokencop. (drenmi)Rails/CreateTableWithTimestampscop. (wata727)Style/ColonMethodDefinitioncop. (rrosenblum)Style/ExtendSelfcop. (drenmi)Rails/RedundantReceiverInWithOptionscop. (koic)Rails/LexicallyScopedActionFiltercop. (wata727)Style/EvalWithLocationcop. (pocke)Rails/Presencecop. (wata727)Bug fixes
Layout/EmptyLinesAroundArguments. (garettarrowood)Style/ConstantNamewith constant names using non-ASCII capital letters with accents. (timrogers)Layout/BlockEndNewlinecop from introducing trailing whitespaces. (bgeuken)Performance/HashEachMethodswhen unused argument(s) exists in other blocks. (pocke)Performance/HashEachMethods. (pocke)...::DateTime. (dpostorivo)Lint/UnneededDisable, which was returning offenses even after being disabled in a comment. (tdeo)EnforcedStyleForEmptyBracesforLayout/SpaceBeforeBlockBracescop. (drenmi)Rails/HasManyOrHasOneDependentaware of multiple associations inwith_options. (koic)Layout/MultilineOperationIndentationwhen an operation spans multiple lines and contains a ternary expression. (rrosenblum)Style/MixinUsagecop. (koic)Style/EmptyElseautocorrection removes comments from branches. (dpostorivo)Style/UnneededPercentQfrom breaking on strings that are concated with backslash. (pocke)Style/PercentLiteralDelimitersincorrectly automatically modifies escaped percent literal delimiter. (koic)Naming/ConstantNamefalse offense on assigning to a nonoffensive assignment. (garettarrowood)Style/HashSyntaxcop when hash is used as unspaced argument. (drenmi)Style/BracesAroundHashParametersauto-correction. (garettarrowood)Style/MixinUsagewhenincludecall is a method argument. (koic)Lint/UnneededSplatExpansion, whenArray.newresides in an array literal. (akhramov)Style/SafeNavigationwhen safe guarding arithmetic operation or assignment. (tiagotex)Style/MinMaxfrom breaking on implicit receivers. (drenmi)Style/SafeNavigationwhen safe guarding comparisons. (tiagotex)Style/RedundantParenthesescop when unspaced ternary is present. (tiagotex)Naming/ConstantNamecop when using frozen object assignment. (koic)Style/SafeNavigationwhen the right hand side is negated. (rrosenblum)Bundler/OrderedGemswhen gems are references from variables (ignores them in the sorting). (tdeo)Changes
Metrics/ParameterLists. (reitermarkus)Style/StderrPuts. (jaredbeck)Lint/RedundantWithIndexcop aware of offset argument. (koic)Metrics/LineLength: Maxwhen generating.rubocop_todo.yml. (jonas054)SupportedStylesfrom "Configuration parameters" in.rubocop_todo.yml. (pocke)Lint/RescueWithoutErrorClasshas been replaced byStyle/RescueStandardError. (rrosenblum)Layout/SpaceInsideBracketsin favor of two new configurable cops. (garettarrowood)define_method. (pocke)Layout/IndentHeredocaware of line length. (pocke)--show-copsoption aware of--force-default-config. (pocke)Lint/MissingCopEnableDirectivecop. (tdeo)Lint/Syntaxcop with the same settings as the default. (tdeo)