Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New cop idea: enforce # rubocop:enable cop after # rubocop:disable cop #4674

Closed
tdeo opened this issue Aug 23, 2017 · 1 comment
Closed

New cop idea: enforce # rubocop:enable cop after # rubocop:disable cop #4674

tdeo opened this issue Aug 23, 2017 · 1 comment
Labels
feature request

Comments

@tdeo
Copy link
Contributor

tdeo commented Aug 23, 2017

Hi,

I'd like to suggest a cop that enforces to find a matching # rubocop:enable statement after a non-inline # rubocop:disable. If the enable statement is not present, people might be writing some code further in the file not covered by some cops without being aware of it.

Let me know how it sounds, I can give a shot at a PR.
@Drenmi
Copy link
Collaborator

Drenmi commented Sep 17, 2017

Makes sense to me. PR welcome. 🙂

@tdeo tdeo mentioned this issue Oct 25, 2017
Closed
@bbatsov bbatsov closed this as completed in e66332f Nov 7, 2017
@dependencies dependencies bot mentioned this issue Dec 12, 2017
Open
@dependencies dependencies bot mentioned this issue Jan 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Drenmi @tdeo