Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --show-cops option aware of --force-default-config #5146

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Nov 26, 2017

Problem

Currently, --show-cops option is not aware of --force-default-config option. It always print a configuration for current directory.
So we need chdir to get a default configuration with --show-cops.

For example

$ cat .rubocop.yml
Layout/Tab:
  Enabled: false

$ rubocop --show-cops Layout/Tab --force-default-config
Layout/Tab:
  Description: No hard tabs.
  StyleGuide: "#spaces-indentation"
  Enabled: false
  IndentationWidth:

Solution

This change will make --show-cops option aware of --force-default-config.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@pocke pocke force-pushed the force-default-config branch from 6b14756 to 06e7672 Compare November 26, 2017 12:29
Problem
===

Currently, `--show-cops` option is not aware of `--force-default-config` option. It always print a configuration for current directory.
So we need chdir to get a default configuration with --show-cops.

For example
---

```bash
$ cat .rubocop.yml
Layout/Tab:
  Enabled: false

$ rubocop --show-cops Layout/Tab --force-default-config
Layout/Tab:
  Description: No hard tabs.
  StyleGuide: "#spaces-indentation"
  Enabled: false
  IndentationWidth:
```

Solution
=====

This change will make `--show-cops` option aware of `--force-default-config`.
@bbatsov bbatsov merged commit 4dfa6b1 into rubocop:master Nov 26, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 26, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants