Style/ConstantName gives a false positive for SCREAMING_SNAKE_CASE with accents #5016
Comments
11 tasks
timrogers
pushed a commit
to timrogers/rubocop
that referenced
this issue
Dec 5, 2017
`Rubocop::Cop::Style::ConstantName` enforces that constant names must be written using SCREAMING_SNAKE_CASE, by comparing them to its regex, `SNAKE_CASE`. Capital letters can have accents, but the regular expression only permits unaccented letters A-Z. This modifies the regular expression to also permit capital letters with accents using [POSIX character classes][], and adds a spec confirming this behaviour. Fixes rubocop#5016. [POSIX character classes]: https://en.wikibooks.org/wiki/Regular_Expressions/POSIX_Basic_Regular_Expressions#Character_classes
bbatsov
pushed a commit
that referenced
this issue
Dec 5, 2017
`Rubocop::Cop::Style::ConstantName` enforces that constant names must be written using SCREAMING_SNAKE_CASE, by comparing them to its regex, `SNAKE_CASE`. Capital letters can have accents, but the regular expression only permits unaccented letters A-Z. This modifies the regular expression to also permit capital letters with accents using [POSIX character classes][], and adds a spec confirming this behaviour. Fixes #5016. [POSIX character classes]: https://en.wikibooks.org/wiki/Regular_Expressions/POSIX_Basic_Regular_Expressions#Character_classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rubocop::Cop::Style::ConstantNameenforces that constant names must be written using SCREAMING_SNAKE_CASE, by comparing them to its regex,SNAKE_CASE.Capital letters can have accents, but the regular expression only permits unaccented letters A-Z. We should also allow capital letters with accents.
Expected behavior
should be permitted by the cop, just as:
is permitted.
Actual behavior
Rubocop detects an offence.
Steps to reproduce the problem
Define a constant using what looks like SCREAMING_SNAKE_CASE, but including capital letterswith accents.
RuboCop version
The text was updated successfully, but these errors were encountered: