Add new Style/EmptyBlockParameter cop
#5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
reviewed
Nov 10, 2017
|
|
||
| it 'registers an offense for an empty block parameter with a lambda' do | ||
| expect_offense(<<-RUBY.strip_indent) | ||
| -> () { do_something } |
There was a problem hiding this comment.
I would much rather have this as a separate cop.
There was a problem hiding this comment.
👍 I'll separate the cop into Style/EmptyBlockParameter and Style/EmptyLambdaParameter.
Drenmi
reviewed
Nov 10, 2017
|
|
||
| def on_block(node) | ||
| empty_arguments?(node) do |args| | ||
| return unless args.loc.expression |
There was a problem hiding this comment.
Can we put this as a meaningfully named method in ArgsNode? 🙂
There was a problem hiding this comment.
Probably. I'll try it.
Drenmi
reviewed
Nov 10, 2017
| module Style | ||
| # This cop checks for delimiters that are pipes or braces for empty | ||
| # block parameters. Delimiters for empty block parameters do not cause | ||
| # syntax errors, but it looks strange. |
There was a problem hiding this comment.
"It looks strange" is a subjective valuation, I guess. Perhaps "are redundant"? 🙂
|
Nice! Didn't even know you could do this without syntax error. 😅 |
- Separate cops - add empty_and_without_delimiters? method to ArgsNode
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop checks delimiters of empty block parameters.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).