fix: move Jest to dev dependencies, close #89

[bahmutov]

• closes Remove jest from dependencies #89

Note: this throws this error, which does not affect the install

Running sanity check... 
Could not update list of known top-level domains for parse-domain because of "Cannot find module '.bin/jest'
Require stack:
- /private/tmp/node_modules/parse-domain/scripts/build-tries.js"

[flotwig]

@bahmutov won't this make the step to build the fresh public suffix list always fail? I have no earthly clue why it requires jest, but it does, or it will throw here and won't complete:

parse-domain/scripts/build-tries.js

Lines 77 to 80 in 9246927

	childProcess.execFileSync(process.execPath, [require.resolve(".bin/jest")], {
	cwd: rootPath,
	encoding: "utf8",
	});

[flotwig]

The line above it says "Running sanity check", so I'm guessing the purpose is to run all the Jest specs using the new data before finalizing it. I guess that makes sense to do but.... it also seems likely that the relevant specs could be extracted, re-written to use basic assertions, and then it wouldn't need the prod dependency on jest.

[bahmutov]

yes, it does include Jest just to run a basic test, which is not good in production mode

[flotwig]

Not to mention the jest test seems to fail: #90 I can also repro locally.

[jhnns]

Yes, Jest is a regular dependency. Jest is not used at runtime but on every npm install. However, some people had problems with this approach (#42) so we will revert it back to manual updates.

[schmod]

@jhnns Anything we can do to help?

[jhnns]

Nope, thanks. It's almost finished :)