Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No parsing number IP domain #102

Closed
alvaro-escalante opened this issue Mar 20, 2020 · 2 comments
Closed

No parsing number IP domain #102

alvaro-escalante opened this issue Mar 20, 2020 · 2 comments
Labels
released

Comments

@alvaro-escalante
Copy link

When trying to parse-domain https://205.174.34.33/blogs/ I get:

TypeError: Cannot read property 'domain' of null
@jhnns
Copy link
Member

jhnns commented Apr 19, 2020

This is an IP, not a domain. parse-domain returns null if it's not a domain, so this is the desired behavior. You can use https://www.npmjs.com/package/is-ip to filter out IPs.

@jhnns jhnns closed this as completed Apr 19, 2020
jhnns added a commit that referenced this issue Apr 23, 2020
@jhnns
feat: Complete rewrite in TypeScript and several bug fixes and improv…
9f38492 
…ements

- Run against [psl example domains](https://raw.githubusercontent.com/publicsuffix/list/master/tests/test_psl.txt). Closes #1
- Add support for international domain names. Fixes #16 #82 and #44
- Only accept hostnames instead of whole URLs. Fixes #49 and #14
- Do not auto update tries on npm install. Fixes #42 #48 and #90
- Use "node-fetch" instead of "got". Fixes #78 and #62
- Use Node's "assert" module instead of Jest for smoke test. Fixes #92 #93 #89 #91
- Recognize IPv4 and IPv6 in hostnames. Fixes #102

BREAKING CHANGE: This release is a complete rewrite in TypeScript. It fixes some long outstanding bugs and comes with improvements we were planning for quite some time. The major changes are: 1. parseDomain does not accept whole URLs anymore. Only the hostname section of a URL is allowed now. 2. We removed the options object. Custom TLDs are returned as "valid but not listed". The parse result contains both the result with private TLDs and without private TLDs. 3. Dropped Node 6 support. We recommend reading the README since the public API as changed quite a lot.
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhnns @alvaro-escalante