Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postinstall on Node.js 12: OutgoingMessage.prototype._headers is deprecated #78

Closed
silverwind opened this issue Jul 10, 2019 · 4 comments
Labels

Comments

@silverwind
Copy link

> node scripts/build-tries.js

Downloading public suffix list from https://publicsuffix.org/list/public_suffix_list.dat... (node:40806) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
ok

See here for details on this deprecation.

@jhnns
Copy link
Member

jhnns commented Aug 10, 2019

It's because we're using an outdated version of got (#62) which is because they don't support all the node versions that we do. We need to deprecate that old node version as well which requires a major version bump.

@silverwind
Copy link
Author

Maybe worth switchting to https://github.com/npm/make-fetch-happen. It comes with proxy support out of the box which is quite valuable to some users.

Thought, I generally would say fetching data updates in post-install scripts should be removed as it makes builds non-deterministic.

@jhnns
Copy link
Member

jhnns commented Aug 11, 2019

Agreed. Related discussion: #42

@jhnns jhnns closed this as completed in 9f38492 Apr 23, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants