check for mib include file #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a mib is compiled, check that the include file is created and placed in the right location. Test added for both normal and umbrella project.
|
i will look into this tomorrow or this weekend |
|
@goertzenator could you take a look at this issue and let us know if it's relevant to this issue? it's a possible dupe but i don't understand mibs well enough to know if the header should also be present in the include dir |
|
i've attempted to solve this issue with #967 by linking the hrl file in priv/mibs/include into the app dir's include file the mib compiler should probably be broken out into it's own provider/plugin eventually, but hopefully this addresses the issue for now |
|
@goertzenator @tsloughter this is good to close now, right? |
|
Yes, please close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mib is compiled, check that the include file is created and placed in the right location.
Test added for both normal and umbrella projects.
Both these tests currently fail, and IIRC for different reasons.
This is the replacement PR for the unmergable #873