-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a small bug in the MIB compiler when building dependencies #948
Conversation
When compiling a dependency with a MIB file the generated hrl file is left in the root project directory in a file called "include". This has the perverse effect of messing up the search path for include files causing any dependencies with files in their "include" directory to fail to build after that.
...by including a patched version of rebar3. There was a small bug in rebar3 when compiling dependencies with MIBs. A PR has been opened with the rebar3 project to fix this long-term: erlang/rebar3#948
+1. Any chance a test could be added for this? |
Sure. I will do that and update the PR. |
OK, I updated the tests and verified that the old code fails and the new code passes. |
related to #909 maybe? |
Fix a small bug in the MIB compiler when building dependencies
Thanks for the contribution! @talentdeficit yeah they seem related. |
i'll investigate whether we still need #909 now that this is merged |
...by including a patched version of rebar3. There was a small bug in rebar3 when compiling dependencies with MIBs. A PR has been opened with the rebar3 project to fix this long-term: erlang/rebar3#948
This PR does subsume 909, however there's a problem with this one: the MIB includes are being placed in the wrong directory. This PR places the MIB includes into Details:
|
ok. if rebar3 and erlang.mk both agree it should go in |
When compiling a dependency with a MIB file the generated hrl file is left in the root project directory in a file called "include". This has the perverse effect of messing up the search path for include files causing any dependencies with files in their "include" directory to fail to build after that.