Rebar compile umbrella tests #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cases in rebar_compile_SUITE can now be run as a plain application AND as an application in an umbrella project. The config "apps" can be thought of as the project directory, and a new config "subject_dir" indicates where the test application is to be created. In "as_application" mode, "apps" and "subject_dir" are identical. Existing cases are backwards compatible with "as_application" mode. In "as_umbrella", "subject_dir" will be some subdirectory of "apps". To be compatible with "as_umbrella", the test case must replace some uses of "apps" with "subject_dir". Some cases have been updated in this patch to demonstrate this, but the main focus here is to establish the dual-use infrastructure.
Check that header file is generated and placed correctly.
|
Note: This branch adds 2 failing tests. Travis CI is reporting this correctly. |
|
Thanks, can you rebase. @talentdeficit have you seen this? |
|
no i missed this. i largely rewrote the compiler test suite with the branch that landed a few days ago so a rebase might be tough. we should definitely land the mib tests though and try to adapt this work if it still makes sense |
|
This will never merge. Closing this PR while I prepare a new one with just the important bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The obvious: This branch generalizes some infrastructure in
rebar_compile_SUITEso that tests can be written once and then run in both umbrella and plain application mode. Existing cases are backwards compatible, but some have been updated to be "dual use".The less obvious: This branch adds a test that reveals multiple problems in MIB compilation.