-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: "Meta Data Table" in Issue Description #14
Comments
I think the example (number of time the issue has been edited and link to the history view) is a good start for an MVP! If this table works it will be easy to add more info but more complicated to remove existing data (maybe not too much technically but from the user experience it might feels strange) Is the meta table represents any edits (on the issue description and on the comments of the issue)? If yes I think it makes sense to only display the meta table on the description issue. We might need to find a way to explain this on the meta table (ie. "Issue/Comments Edit Cout" 🤔 ) as it might not be obvious at a first sight. |
@SimonLab good question. I feel that we should test this. Most comments don't have edits so it won't be too bad if we have the Meta Table in any comment that has an edit. For now (MVP) let's only insert the Meta Table in the first comment and then get User-Feedback on the Feature ... |
Thanks for the clarification @nelsonic and agree let's focus on the edit history of the issue description instead of the comments at least for the MVP. The only other information I would add on the meta table is a link/logo to the github app on the marketplace so that users can install the app easily via the meta table |
@SimonLab on the subject of having a link/logo in the Meta Table, |
@nelsonic - what priority do you think this should be? Perhaps 2 or 3? |
As soon as we are tracking the history of an repo's issues we want to make that clear. |
@nelsonic @SimonLab - if we only display the table in top comment then where would clicking on the link take you? At the moment we're organising history pages by each comment not by issue. So on that basis I would start with having one per comment (where edits exist). @nelsonic - so for the MVP are you suggesting we do the first comment (with the number of edits of all comments on the issue) or the first comment with just # edits listed for that one comment? First step:
Notes on API Patch Method Also, the PUT method is idempotent. PUTting the same data multiple times to the same resource, should not result in different resources, while POSTing to the same resource can result in the creation of multiple resources. I also agree, the smaller the table, the better. This is what the table looks like with a blank header which is one option:
|
@Cleop, Yeah, I'm suggesting that we The history page should be for the whole issue. Also, yes, the table will only be inserted into the First Comment exactly Once. Our app will know to ignore edits/updates made by the app. so there will be no "infinite loop" 🔁 |
#14 Adds comment to code for the meta table
As a
user
of the GitHub Backup App,I want
to see at a glance if an issue has "version history"so that
I know there is "history" and I can click to see it!Acceptance Criteria
Meta Table should be inserted into the issue description when the issue is Created.
e.g:
<!-- avoid editing below this line to preserve issue history -->
(see below)Minimise space occupied by the table to Two Rows to avoid clutter:
Heading (Key) & Row-Cell (Value) >> see below for example.
Display the revision count for the issue.
We already have a "Proof of Concept" for using SVG as a Counter: http://hits.dwyl.io
e.g:
Display a "short link" (dependent on the App / Domain Name chosen. see: Project / App Name ? #13)
Optional (Nice-to-Have)
Question / Discussion:
What other info would it be useful to display in the "Meta Table"?
(or should we "keep it simple for MVP and ask users once deployed...?)
Example:
The text was updated successfully, but these errors were encountered: