Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect staging with github app to receive webhooks #63

Open
Cleop opened this issue Mar 7, 2018 · 7 comments
Open

Connect staging with github app to receive webhooks #63

Cleop opened this issue Mar 7, 2018 · 7 comments

Comments

@Cleop
Copy link
Member

Cleop commented Mar 7, 2018

Currently we don't have any data on the heroku staging site because our github app webhook url is targeted on our ngrok url for localhost.

@SimonLab informs me that for the dwylbot github app he created 'dwylbot' as a new github user and then pointed the app created on the 'dwylbot' account to the staging url.

I can think of a couple of options to set up staging with data:

  • We could create a new account as @SimonLab did before specifically for gh-backup
  • or we could create a generic 'dwyl' account that we can use for future instances like this so that we don't have to create a new account each time
  • or we could set this app up on dwylbot (or change the name of the dwylbot user if that's possible? but then would messages no longer appear as if they were written by 'dwylbot'?)
  • or we could create a second github app on my account and point that one at staging

@nelsonic - do you have any thoughts on this?

@nelsonic
Copy link
Member

nelsonic commented Mar 9, 2018

@Cleop please link staging to this repo. 😮

@nelsonic nelsonic removed the blocker label Mar 9, 2018
@nelsonic nelsonic assigned Cleop and unassigned nelsonic Mar 9, 2018
@Cleop
Copy link
Member Author

Cleop commented Mar 9, 2018

@nelsonic - I mean for the creation of the 'github app', you have to create a 'github app' in your dev settings as a user rather than attaching it to a repo. Does that make sense?

@Cleop Cleop assigned nelsonic and unassigned Cleop Mar 9, 2018
@Cleop Cleop added the question label Mar 9, 2018
@Cleop
Copy link
Member Author

Cleop commented Mar 9, 2018

We also need a new user because:
#14 (comment)

When we count the number of edits to a comment and then update (edit) the comment meta table to reflect this we will get stuck in an infinite loop unless we filter out the actions of the app by user, giving the app a distinctive user whose actions won't be counted.

@nelsonic
Copy link
Member

nelsonic commented Mar 9, 2018

@Cleop https://github.com/gibuio related to #13 (CC: @iteles should we register the "gibu.io" domain?)
image

@iteles
Copy link
Member

iteles commented Mar 9, 2018

Replied on the name in that issue!

@Cleop Cleop added the T1h label Mar 12, 2018
@nelsonic nelsonic added this to the MVP milestone Mar 12, 2018
@SimonLab
Copy link
Member

@nelsonic @iteles is https://github.com/gitbuco ours?
Also we might want to create two different Github apps one for staging and one for production like this the features tested on staging won't "break" any repositories (ex: adding another meta table on the description of the issues) which are also linked to the production app

@Cleop
Copy link
Member Author

Cleop commented Mar 13, 2018

external-dependency label added as we're awaiting the login details for the user account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants