Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14 Adds comment to code for the meta table #106

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Conversation

Cleop
Copy link
Member

@Cleop Cleop commented Mar 19, 2018

#14 Adds comment to code for the meta table

Refactors code to make credo happy 😄

@Cleop Cleop self-assigned this Mar 19, 2018
@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #106 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   99.51%   99.51%   +<.01%     
==========================================
  Files          19       19              
  Lines         206      207       +1     
==========================================
+ Hits          205      206       +1     
  Misses          1        1
Impacted Files Coverage Δ
lib/app_web/controllers/meta_table.ex 100% <100%> (ø) ⬆️
lib/app/helpers/user.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfd43c...d72b374. Read the comment docs.

@Cleop Cleop assigned nelsonic and unassigned Cleop Mar 19, 2018
@Cleop Cleop requested a review from nelsonic March 19, 2018 16:41
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cleop looks good. 👍

@nelsonic nelsonic merged commit 2ffe4be into master Mar 20, 2018
@nelsonic nelsonic deleted the meta-table-note branch March 20, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants