Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Shortcuts: Refactor global shortcuts to be co-located. #274

Closed
seanparsons opened this issue Jul 16, 2020 · 0 comments · Fixed by #481
Closed

Keyboard Shortcuts: Refactor global shortcuts to be co-located. #274

seanparsons opened this issue Jul 16, 2020 · 0 comments · Fixed by #481
Assignees
@seanparsons

Comments

@seanparsons
Copy link
Contributor

Refactor all global shortcuts to somewhere in editor.tsx or similar. Effectively a cleanup pass to consolidate logic which should all be co-located.
@seanparsons seanparsons mentioned this issue Jul 16, 2020
Closed
@seanparsons seanparsons self-assigned this Aug 25, 2020
seanparsons added a commit that referenced this issue Aug 27, 2020
@seanparsons
refactor(shortcuts) Pull all the global shortcuts into one place.
acf12a7 
- Fixes #274.
- Extracted the logic from `editor-interactions.ts` and `canvas.ts`
  pulling that into `global-shortcuts.ts`. In the process refactoring
  out the inspector tab handling check.
- Separated out browser shortcut prevention so that those can still
  be applied even if the shortcuts don't match them.
@seanparsons seanparsons mentioned this issue Aug 27, 2020
Merged
seanparsons added a commit that referenced this issue Aug 28, 2020
@seanparsons
refactor(shortcuts) Pull all the global shortcuts into one place. (#481)
9a77865 
- Fixes #274.
- Extracted the logic from `editor-interactions.ts` and `canvas.ts`
  pulling that into `global-shortcuts.ts`. In the process refactoring
  out the inspector tab handling check.
- Separated out browser shortcut prevention so that those can still
  be applied even if the shortcuts don't match them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanparsons seanparsons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pull all the global shortcuts into one place. concrete-utopia/utopia
1 participant
@seanparsons