Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan and discuss how to fix keyboard shortcuts #106

Closed
Rheeseyb opened this issue Jun 16, 2020 · 3 comments
Closed

Plan and discuss how to fix keyboard shortcuts #106

Rheeseyb opened this issue Jun 16, 2020 · 3 comments
Assignees

Comments

@Rheeseyb
Copy link
Contributor

This one isn't a simple bug fix, but rather a prompt for a discussion on how to fix / centralise keyboard shortcuts. Right now they are spread out throughout the code (some are checked as part of action handling, some are in event handlers, etc.) despite a lot of them being "global". The overall goals should be:

  1. We can support user configuration of the shortcuts
  2. We have a centralised place for adding and editing global shortcuts
  3. Shortcuts that can't live in that centralised place are obvious to find (not just from the perspective of "where would this shortcut live", but also "what other shortcuts might exist somewhere?")
  4. We can support different OSes (this should be a case of determining which of meta/cmd vs ctrl to use based on a library that determines which OS the user is using)
@maltenuhn
Copy link
Member

My take

  1. We should build this in a way that makes it the easiest for us to experiment quickly.
  2. We should assume that user configurability is an inevitability

Personally, I really like the approach Monaco / VSCode took with keybindings in a JSON file: https://code.visualstudio.com/docs/getstarted/keybindings#:~:text=All%20keyboard%20shortcuts%20in%20VS,This%20will%20open%20your%20keybindings.

@alecmolloy
Copy link
Contributor

alecmolloy commented Jul 6, 2020

#231 is dependent on point №2 being fixed here

@seanparsons seanparsons self-assigned this Jul 15, 2020
@seanparsons
Copy link
Contributor

The following tickets have been created:
#272
#273
#274
#275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants