fix: trim nextLink before slicing
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berkmann18
approved these changes
Aug 16, 2022
|
Hey @Berkmann18, I can't seem to access the logs of the failing check. Do I need permissions or is there another way I can see what's going on there? |
tenshiAMD
changed the title
nextLink before slicingnextLink before slicing
tenshiAMD
changed the title
nextLink before slicingnextLink before slicing
|
🎉 This PR is included in version 6.20.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tenshiAMD
added a commit
that referenced
this pull request
Sep 13, 2022
* origin/master: (85 commits) refactor: log full error stack on error (#316) chore: fix status badges (#315) docs: add JoshuaKGoldberg as a contributor for bug (#314) fix: incorrect usage of `tbody` (#311) fix: trim `nextLink` before slicing (#309) fix: set default value as `7` for `contributorsPerLine` (#139) chore(deps): bump dependencies and devDeps (#298) refactor: add tbody to contributors table (#307) docs: add Lucas-C as a contributor for doc (#306) fix: scriptName + improving usage messages (#305) docs: add vapurrmaid as a contributor (#304) chore(deps): CVE-2021-23337 in inquirer->lodash (#303) docs: add SirWindfield as a contributor (#297) feat: add namespaced token (#296) docs: add LaChapeliere as a contributor (#292) feat(contribution-types): add research contribution type (#291) docs: add darekkay as a contributor (#290) feat: display a meaningful error when the config file is missing (#288) docs: add melink14 as a contributor (#285) docs: add jdalrymple as a contributor (#264) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all! I think I found and fixed a small bug; using this PR to start a discussion. When I tried updating Redwood's all contributors table, I got a
Only absolute URLs are supportederror, so I dug in a bit. This is the command I ran:And here's the
.all-contributorsrcfile: https://github.com/redwoodjs/redwood/blob/main/tasks/all-contributors/.all-contributorsrc.I stepped through the code and narrowed it down; the error's happening in the
getNextLinkfunction. Here's the value forlink:'<https://api.github.com/repositories/191051391/contributors?per_page=100&page=1>; rel="prev", <https://api.github.com/repositories/191051391/contributors?per_page=100&page=3>; rel="next", <https://api.github.com/repositories/191051391/contributors?per_page=100&page=3>; rel="last", <https://api.github.com/repositories/191051391/contributors?per_page=100&page=1>; rel="first"'The function splits
linkon commas and looks forrel=next. In this case, it's the second link. So splitting it results in:That means the next call (
return nextLink.split(';')[0].slice(1, -1);) results in:When another function tries to fetch this link, it throws.
It seems like all we need to do is trim the string before slicing, but let me know what you think!