Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch all-contributors-cli #5356

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Patch all-contributors-cli #5356

merged 2 commits into from
Apr 29, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Apr 29, 2022 •
edited
Loading

If you run all contributors on the redwoodjs/redwood repo, you'll the following error:

$ yarn all-contributors check --config .all-contributorsrc
Only absolute URLs are supported

I stepped through the code and narrowed it down; it's just that a string isn't being sliced properly. I opened a PR for the fix in the all-contributors-cli repo: all-contributors/cli#309. But I'm not sure when it'll get merged so I applied a patch for it here. I'll handle updating the package when it gets fixed.

Now when you run the command:

$ yarn all-contributors check --config .all-contributorsrc
Missing contributors in .all-contributorsrc:
    peterp, thedavidprice, renovate[bot], jtoar, cannikin, dac09, Tobbe, dependabot[bot], dthyresson, mojombo, RobertBroersma, kimadeline, callingmedic911, aldonline, forresthayes, simoncrypta, KrisCoulson, realStandal, virtuoushub, m3t, alicelovescake, flybayer, dependabot-preview[bot], mattmurph9, jessicard, petemccarthy, Philzen, vikotar, ajcwebdev, Plazide, chenliu9, MJ1992, zpeters, agiannelli, benmandr, COCL2022, exu3, EricKit, carusog, ianwalter, jjbowman2, elitan, zygopleural, leothorp, mnapoli, nikfp, Olyno, robertwt7, apecollector, ccnklc, codesee-maps[bot], cremno, dkmooers, hbellahc, zzyyxxww, llmaboi
Unknown contributors found in .all-contributorsrc:
vikash-eatgeek, pepibumur, shahbaz17, redstab, AlejandroFrias

@jtoar jtoar added topic/ops-&-contributing-dx release:chore This PR is a chore (means nothing for users) labels Apr 29, 2022
@jtoar jtoar self-assigned this Apr 29, 2022
@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

✅ Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 79930d8
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/626ba239a356e80008cc0cd4

@jtoar jtoar changed the title Patch all contributors cli Patch all-contributors-cli Apr 29, 2022
@jtoar jtoar merged commit eea765d into main Apr 29, 2022
@jtoar jtoar deleted the ds-patch-all-contributors-cli branch April 29, 2022 12:37
@jtoar jtoar added this to the next-release milestone Apr 29, 2022
@jtoar jtoar mentioned this pull request Apr 29, 2022
Merged
@jtoar jtoar modified the milestones: next-release, v1.3.0 Apr 30, 2022
dac09 added a commit to dac09/redwood that referenced this pull request May 2, 2022
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into fix/run-rwjs…
8c09ed0 
…-core-tests

* 'main' of github.com:redwoodjs/redwood: (668 commits)
  Fix broken link in authentication.md (redwoodjs#5394)
  Update local-postgres-setup.md (redwoodjs#5353)
  modify typescript example (redwoodjs#5377)
  fix(deps): update dependency core-js to v3.22.3 (redwoodjs#5376)
  fix(deps): update dependency @types/node to v16.11.32 (redwoodjs#5374)
  fix(deps): update prisma monorepo to v3.13.0 (redwoodjs#5375)
  chore(deps): update dependency typescript to v4.6.4 (redwoodjs#5372)
  chore(deps): update dependency nodemon to v2.0.16 (redwoodjs#5364)
  fix(docs): add WindiCSS in setup ui list (redwoodjs#5369)
  chore(deps): update dependency @nhost/nhost-js to v1.1.6 (redwoodjs#5363)
  Add back git fetch step for lerna
  chore(deps): update dependency @clerk/clerk-sdk-node to v3.3.10 (redwoodjs#5358)
  fix(deps): update dependency @types/node to v16.11.28 (redwoodjs#5326)
  update all contributors (redwoodjs#5357)
  Patch all-contributors-cli (redwoodjs#5356)
  Remove unused `SubmitHandler` in example JavaScript code (redwoodjs#5352)
  Use GraphQL Codegen to generate more accurate resolver types (redwoodjs#5216)
  chore(deps): update dependency @clerk/clerk-sdk-node to v3.3.8 (redwoodjs#5345)
  fix(deps): update dependency jest-watch-typeahead to v1.1.0 (redwoodjs#5339)
  Update yarn.lock
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtoar jtoar

Labels
release:chore This PR is a chore (means nothing for users) topic/ops-&-contributing-dx
Projects
No open projects
Release
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jtoar