-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contribution-types): add research contribution type #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a research contribution type with microscope emoji, for people doing literature review, code prototyping or any other research-related activity. #446
Fix name of added type (was "question" due to copy pasting) and position (alphabetical order) #446
Berkmann18
requested changes
Oct 8, 2020
Berkmann18
changed the title
feat(contribution-types.js): add research contribution type
feat(contribution-types): add research contribution type
Oct 8, 2020
Co-authored-by: Maximilian Berkmann <[email protected]>
Berkmann18
approved these changes
Oct 9, 2020
@all-contributors Please add @LaChapeliere for code |
I've put up a pull request to add @LaChapeliere! 🎉 |
🎉 This PR is included in version 6.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Guardian88
reviewed
Oct 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackguard88
tenshiAMD
added a commit
that referenced
this pull request
Sep 13, 2022
* origin/master: (85 commits) refactor: log full error stack on error (#316) chore: fix status badges (#315) docs: add JoshuaKGoldberg as a contributor for bug (#314) fix: incorrect usage of `tbody` (#311) fix: trim `nextLink` before slicing (#309) fix: set default value as `7` for `contributorsPerLine` (#139) chore(deps): bump dependencies and devDeps (#298) refactor: add tbody to contributors table (#307) docs: add Lucas-C as a contributor for doc (#306) fix: scriptName + improving usage messages (#305) docs: add vapurrmaid as a contributor (#304) chore(deps): CVE-2021-23337 in inquirer->lodash (#303) docs: add SirWindfield as a contributor (#297) feat: add namespaced token (#296) docs: add LaChapeliere as a contributor (#292) feat(contribution-types): add research contribution type (#291) docs: add darekkay as a contributor (#290) feat: display a meaningful error when the config file is missing (#288) docs: add melink14 as a contributor (#285) docs: add jdalrymple as a contributor (#264) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add a research contribution type with microscope emoji, for people doing literature review, code
prototyping or any other research-related activity.
Part 2/3 of #446
Why:
For open science projects or dev projects with a research component, people carrying out research tasks cannot always be acknowledged with the existing types.
Adding the type description and emoji to the list of types available to the CLI tool.
Checklist:
I'm not really familiar with npm so I'm not sure how to install my modified version of the cli tool to test it. Any help?
Bot PR following.