-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Creality Ender-3 S1 Plus #4674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Marking this as a draft as I am getting lots of feedback from Gozania in #4669 |
@SoftFever I am running into a strange issue where even though I list the correct bed model/texture to use, they are not. What am I missing? Even when I tell the program what texture should be used, it isn't shown, while the model is. |
Ok, everything should be working now! |
SoftFever
approved these changes
Mar 29, 2024
SoftFever
pushed a commit
that referenced
this pull request
Apr 13, 2024
* Add Creality Ender-3 S1 Plus * Misc * Fix nozzle_diameter * Add printer_variant value * Change build plate model/texture to use Ender-3 V3 SE * Enable mesh leveling * Up max travel acceleration to 5000 * Enable infill_combination * Add Draft profiles * Change buildplate model/texture * Fix build plate model * Add retraction & detraction speed & change retraction length * Add filament_ to the beginning * Revert retraction & detraction speed & retraction length * Tests Trying to change retract and detract speed as well as retraction length Also trying to have Z-hop only happen on top layers * Apply new values to other nozzles * disable z_hop * Lower build plate model * Resolve merge conflicts * temporarily remove Ender-3 S1 Plus * Re-add Ender-3 S1 Plus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4669, closes #3707