Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to split out initialization and registration #21787

Merged
merged 17 commits into from
Dec 11, 2024
Merged

Conversation

ConradIrwin
Copy link
Member

@ConradIrwin ConradIrwin commented Dec 10, 2024

Still TODO:

  • Factor out start_language_server so we can call it on register (instead of on detect language)
  • Only call register in singleton editors (or when editing/go-to-definition etc. in a multibuffer?)
  • Refcount on register so we can unregister when no buffer remain
  • (maybe) Stop language servers that are no longer needed after some time

Release Notes:

  • Fixed language servers starting when doing project search
  • Fixed high CPU usage when ignoring warnings in the diagnostics view

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 10, 2024
@ConradIrwin ConradIrwin merged commit 13a81e4 into main Dec 11, 2024
12 checks passed
@ConradIrwin ConradIrwin deleted the fewer-diagnostics branch December 11, 2024 21:05
@maan2003 maan2003 mentioned this pull request Dec 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants