Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multibuffers: go to definition no longer works #22773

Open
1 task done
silvenon opened this issue Jan 7, 2025 · 3 comments · May be fixed by #22958
Open
1 task done

Multibuffers: go to definition no longer works #22773

silvenon opened this issue Jan 7, 2025 · 3 comments · May be fixed by #22958
Labels
bug [core label] multi-buffer navigation Feedback for workspace navigation, breadcrumbs, definitions, files, panels, etc regression A bug that was introduced in a recent release

Comments

@silvenon
Copy link

silvenon commented Jan 7, 2025

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Unlike #16619, which reports that going to definition doesn't work at all, I'm experiencing a lack of a different functionality which used to work — going to definition straight from the multibuffer, which was a killer feature 🔥

Now in order to go to the defintion I first have to open the file, and then going to defintion will work.

I'm using TypeScript and TSX.

Zed Version and System Specs

Zed: v0.167.2 (Zed)
OS: macOS 15.2.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

Screenshot 2025-01-07 at 15 27 10

In Vim mode using g d inside of these import statements used to work straight from the multibuffer, but for a while now it doesn't anymore.

@silvenon silvenon added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jan 7, 2025
@baldwindavid
Copy link
Contributor

Yeah, same here in elixir. A given excerpt has to be open in another tab in order for go to definition and even hover to work within the excerpt.

@JosephTLyons JosephTLyons added multi-buffer navigation Feedback for workspace navigation, breadcrumbs, definitions, files, panels, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 9, 2025
@JosephTLyons JosephTLyons added the regression A bug that was introduced in a recent release label Jan 9, 2025
@filipwiech
Copy link

filipwiech commented Jan 10, 2025

CC @osiewicz, might be a side effect of #21787 (not sure if intended or not)? 🤔

@osiewicz
Copy link
Contributor

Yup @filipwiech , you're spot on - it is most likely an unintended consequence of this PR; we should also send out "DidOpen" notification when the user selects something within the excerpt - right now we only do it when an excerpt is edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] multi-buffer navigation Feedback for workspace navigation, breadcrumbs, definitions, files, panels, etc regression A bug that was introduced in a recent release
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants