Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all console format grey to dim #1702

Merged
merged 1 commit into from
Nov 6, 2016

Conversation

tribou
Copy link
Contributor

@tribou tribou commented Nov 5, 2016

Summary
This change fixes #1699.

Test plan
Two ConsoleReporter snapshot tests failed when running the test suite. I assume that should be expected since the purpose of this change is to fix the console coloring for console reporter commands. However, let me know if I'm misunderstanding.*

In comparison with the screenshots in #1699, here is the npm-linked fix working with the correct console coloring:
screen shot 2016-11-05 at 5 01 13 pm

*Update: I realized I needed to update the jest snapshot for the ConsoleReporter tests.

Add updated jest snapshot for ConsoleReporter
@tribou tribou force-pushed the fix-1699-output-solarized branch from 7d678ae to 390c054 Compare November 5, 2016 22:17
@bestander
Copy link
Member

cc @Daniel15 who has a bit of context

@Daniel15
Copy link
Member

Daniel15 commented Nov 6, 2016

All my context was from @tribou's comments on #1699 😛

@Daniel15 Daniel15 merged commit 5787ace into yarnpkg:master Nov 6, 2016
bestander pushed a commit to bestander/yarn that referenced this pull request Nov 9, 2016
Add updated jest snapshot for ConsoleReporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Yarn output not compatible with a Solarized Dark theme
3 participants