Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Yarn output not compatible with a Solarized Dark theme #1699

Closed
tribou opened this issue Nov 5, 2016 · 4 comments · Fixed by #1702
Closed

Some Yarn output not compatible with a Solarized Dark theme #1699

tribou opened this issue Nov 5, 2016 · 4 comments · Fixed by #1702

Comments

@tribou
Copy link
Contributor

tribou commented Nov 5, 2016

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Some of the default yarn output colors are not compatible with the popular Solarized Dark theme.

screen shot 2016-11-05 at 10 02 16 am

(Highlighting reveals the hidden output)
screen shot 2016-11-05 at 10 02 30 am

If the current behavior is a bug, please provide the steps to reproduce.

  1. Install the Solarized Dark them for iTerm2
  2. Use yarn to install/sync new packages in any given project.

What is the expected behavior?
I should be able to read all of the yarn output easily by default when using a Solarized Dark theme.

Please mention your node.js, yarn and operating system version.
OSX 10.11.6
Node v6.9.1
Yarn v0.16.1

npm/npm#12843 is a good reference for how this issue was resolved for npm. 😄

This chalk issue recommends using dim instead of grey for coloring. I can try my luck with a PR to see if that works.

@wyze
Copy link
Member

wyze commented Nov 5, 2016

Sure @tribou, send a PR!

tribou added a commit to tribou/yarn that referenced this issue Nov 5, 2016
tribou added a commit to tribou/yarn that referenced this issue Nov 5, 2016
Add updated jest snapshot for ConsoleReporter
@Daniel15
Copy link
Member

Daniel15 commented Nov 5, 2016

This sounds like a bug with Solarized Dark rather than with Yarn (seems like it's overriding some colours but not all, or something like that?), but nonetheless thanks for the pull request! 😄

@tribou
Copy link
Contributor Author

tribou commented Nov 6, 2016

@Daniel15 You are definitely correct! Unfortunately, the infamous issue altercation/solarized#220 from September of 2012 is evidence that this may not be resolved on the solarized side any time soon. ☹️ This has been an issue with so many projects over the years (mochajs/mocha#802, expressjs/express#1700, yeoman/generator#397, chalk/chalk#40, npm/npm#12843, gulpjs/gulp#654, hapijs/lab#592... just a quick survey 😄 ).

There was talk of forking the solarized project lately in altercation/solarized#355, so we'll see if anything else happens soon...

@Daniel15
Copy link
Member

Daniel15 commented Nov 6, 2016

Thanks for the very thorough comment, @tribou! I appreciate the insight :) Hopefully someone forks Solarized and fixes it... It seems silly for every single project to have to adjust their colours just because one theme is not configured properly.

Daniel15 pushed a commit that referenced this issue Nov 6, 2016
Add updated jest snapshot for ConsoleReporter
bestander pushed a commit to bestander/yarn that referenced this issue Nov 9, 2016
Add updated jest snapshot for ConsoleReporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants