Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android & iOS pick wrong index file #132

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Android & iOS pick wrong index file #132

merged 1 commit into from
Jul 26, 2020

Conversation

r0b0t3d
Copy link
Contributor

@r0b0t3d r0b0t3d commented Jul 4, 2020

#115
In my experience, android and ios always pick index.js file instead of index.android.js or index.ios.js. This PR just rename index to orientation then create a single index.js that export module from orientation file

@mars-lan
Copy link
Contributor

Confirmed that #115 broke android & ios at head. Please merge this fix in @wonday

@wonday wonday merged commit c0b1e07 into wonday:master Jul 26, 2020
@wonday
Copy link
Owner

wonday commented Jul 26, 2020

Thank @mars-lan confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r0b0t3d @mars-lan @wonday