-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore on web and desktop #115
Conversation
Thank you. |
A suggestion is to use |
@euharrison then wouldn't it break on windows? And this package has some difference between ios and android. |
Hi, I got problem with android and ios. It always run code in @wonday This PR breaks |
@r0b0t3d there is some broken setup where this happens. If this PR breaks for everyone how does my app on AppStore and play-store works just fine? |
@sayem314 Did you point to master branch in your package.json? |
@sayem314 waiting to hear from you. If everything works well on your side, I will create another PR to see whether there is other folks got same problem like me. |
@r0b0t3d there is only one branch. |
Your PR got merged but not release yet. If you'd like to check out your PR, please run this
|
This PR properly handles platform-specific code, on web and desktop instead of throwing error it would simply ignore for cross-platform compatibility.