Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v4.7.0 #405

Merged
merged 1 commit into from
May 6, 2022
Merged

Prepare v4.7.0 #405

merged 1 commit into from
May 6, 2022

Conversation

fbuys
Copy link
Collaborator

@fbuys fbuys commented May 6, 2022

Check list:

This PR closes #404.

We updated the changelog and rubycritic/version in preparation for the v4.70 release.

Copy link
Collaborator

@nunosilva800 nunosilva800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @fbuys and :shipit: 🚀

@fbuys
Copy link
Collaborator Author

fbuys commented May 6, 2022

@nunosilva800 could you approve the workflow please?

@fbuys
Copy link
Collaborator Author

fbuys commented May 6, 2022

@nunosilva800 could you kindly tell me if there is something I did wrong to cause all the failures?

@nunosilva800
Copy link
Collaborator

I'm not entirely sure what could be wrong.
For ruby 2.4, error is:

ArgumentError: wrong number of arguments (given 4, expected 1)
/home/runner/work/rubycritic/rubycritic/vendor/bundle/ruby/2.4.0/gems/psych-4.0.3/lib/psych.rb:323:in `safe_load'
/opt/hostedtoolcache/Ruby/2.4.10/x64/lib/ruby/2.4.0/rubygems/safe_yaml.rb:31:in `safe_load'

But it was successful yesterday: https://github.com/whitesmith/rubycritic/runs/6308456694?check_suite_focus=true 🤔

To be honest... ruby versions up to 2.6 including, are no longer under the official maintenance plan. Perhaps we should remove these versions from the test runs.

@etagwerker wdyt?

@etagwerker
Copy link
Collaborator

I think we can remove ruby-2.4.x from the test suite runs. I tried to run the test suite locally w/ 2.4.10 and I found this issue:

➜  rubycritic git:(main) ✗ bundle
Fetching gem metadata from https://rubygems.org/
Fetching gem metadata from https://rubygems.org/.......
simplecov-0.21.2 requires ruby version >= 2.5.0, which is incompatible with the current version, ruby 2.4.10p364

Locally running the test suite with 2.5.x worked for me, so I'm assuming GitHub Actions is currently borked due to some random thing (?)

I'm gonna go ahead and merge this PR so that we can release 4.7.0.

I've submitted #406 so we don't lose track of this. 😄

@etagwerker etagwerker merged commit b7a5ea8 into whitesmith:main May 6, 2022
@rishijain rishijain mentioned this pull request May 11, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v4.7.0
3 participants