Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Ruby 2.4.x #406

Closed
3 tasks done
etagwerker opened this issue May 6, 2022 · 0 comments · Fixed by #407
Closed
3 tasks done

Drop support for Ruby 2.4.x #406

etagwerker opened this issue May 6, 2022 · 0 comments · Fixed by #407
Labels
good first issue

Comments

@etagwerker
Copy link
Collaborator

etagwerker commented May 6, 2022 •
edited by nunosilva800
Loading

A couple of things that would be needed:

  • Drop ruby 2.4.x from test suite config -- Stop running the test suite with ruby 2.4
  • Add documentation to the README to point users in the right direction so they can figure out if their ruby version is supported
  • Add required_ruby_version to the gemspec file and make it > 2.4
@etagwerker etagwerker mentioned this issue May 6, 2022
Merged
3 tasks
@rishijain rishijain mentioned this issue May 9, 2022
Merged
1 task
nunosilva800 added a commit that referenced this issue May 13, 2022
@nunosilva800
Update README with supported ruby versions
ab92ed7 
Note which versions of Ruby are compatible with RubyCritic.

Part of #406
This was referenced May 13, 2022
Merged
Closed
nunosilva800 added a commit that referenced this issue May 23, 2022
@nunosilva800
Update README with supported ruby versions (#408)
d5afb46 
Note which versions of Ruby are compatible with RubyCritic.

Part of #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop support for ruby 2.4.x rishijain/rubycritic
1 participant
@etagwerker