Eliminate RuboCop offenses to make CI build pass. #156
Conversation
|
LGTM! Thanks |
| def self.method_missing(method, *args, &block) | ||
| configuration.public_send(method, *args, &block) | ||
| end | ||
| # rubocop:enable Style/MethodMissing |
There was a problem hiding this comment.
Hmmm, lets rather put this in our configuration file and not in our codebase.
|
One comment and lgtm ;) |
|
I tried to resolve the issue by adding the required So I have disabled it again, but this time in the Once the Rubocop issue is resolved, the exclusion can be removed and everything will be good. |
|
Adding |
| @@ -29,7 +29,15 @@ def self.set(options = {}) | |||
| end | |||
|
|
|||
| def self.method_missing(method, *args, &block) | |||
| configuration.public_send(method, *args, &block) | |||
| if configuration | |||
There was a problem hiding this comment.
Wait, why is this guard now necessary?
There was a problem hiding this comment.
It was a way to get the super into the method_missing to appease Rubocop.
It may just be better to disable the cop and put the code back how it was, but I wanted to at least present a version of the code that didn't raise any warnings.
There was a problem hiding this comment.
Yeah, lets rather disable the cop.
Then pls squash your PR to one commit afterwards so we cn merge this bad boy ;)
```
lib/rubycritic/configuration.rb:31:5: C: When using method_missing, define respond_to_missing? and fall back on super.
def self.method_missing(method, *args, &block) ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/rubycritic/core/analysed_module.rb:30:10: C: Use methods_count.zero? instead of methods_count == 0.
if methods_count == 0
^^^^^^^^^^^^^^^^^^
```
1) Add self.respond_to_missing? method to Config module.
But disabled `Style/MethodMissing` check in `.rubocop_todo.yml`,
since adding a `super` call does not make sense in this case.
2) Changed `methods_count == 0` to `methods_count.zero?`
3) Ignore Rake "boolean parameter" warning for respond_to_missing?
since it implements a Ruby defined method signature:
respond_to_missing?(symbol, include_all = false)
Insti
force-pushed
the
Fix_rubocop_offenses
branch
from
fb928c3 to
5c6ec18
Compare
|
Made changes discussed in #156 (diff) and squashed. |
|
Awesome, merged, thanks! |
Style/MethodMissingcheck for that method.methods_count == 0tomethods_count.zero?