Merge pull request #156 from Insti/Fix_rubocop_offenses

Eliminate RuboCop offenses to make CI build pass.
whitesmith · Aug 4, 2016 · 8ec40ed · 8ec40ed
2 parents 0f4f91c + 5c6ec18
commit 8ec40ed
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -34,3 +34,9 @@ Style/ClassVars:
 # SupportedStyles: use_perl_names, use_english_names
 Style/SpecialGlobalVars:
   Enabled: false
+
+# Offense count: 1
+Style/MethodMissing:
+  Exclude: 
+    - 'lib/rubycritic/configuration.rb'
+
diff --git a/.todo.reek b/.todo.reek
@@ -136,3 +136,6 @@ UncommunicativeParameterName:
 ClassVariable:
   exclude:
   - Rubycritic::SourceControlSystem::Base
+BooleanParameter: 
+  exclude:
+  - Rubycritic::Config#self.respond_to_missing?
diff --git a/lib/rubycritic/configuration.rb b/lib/rubycritic/configuration.rb
@@ -31,5 +31,9 @@ def self.set(options = {})
     def self.method_missing(method, *args, &block)
       configuration.public_send(method, *args, &block)
     end
+
+    def self.respond_to_missing?(symbol, include_all = false)
+      configuration.respond_to_missing?(symbol) || super
+    end
   end
 end
diff --git a/lib/rubycritic/core/analysed_module.rb b/lib/rubycritic/core/analysed_module.rb
@@ -27,7 +27,7 @@ def rating
     end
 
     def complexity_per_method
-      if methods_count == 0
+      if methods_count.zero?
         'N/A'
       else
         complexity.fdiv(methods_count).round(1)