build: Make build dependency on zip and xz optional
#5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
zip optionalzip and xz optional
|
Got it, sounds good 👍 |
syrusakbary
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build script of
wasmeronly depends onzipif the featurewamris enabled and only depends onxzifv8is enabled. So make the cargo feature follow it. I'm sending this PR because unnecessary dependency onzip=>zstd-sysis blocking next.js builds.See: vercel/next.js#74580
CI Run: https://github.com/vercel/next.js/actions/runs/12702533956/job/35408913334