build: Update `swc_core` to `v10.1.0` #74580

kdy1 · 2025-01-07T10:18:05Z

What?

Update swc crates to https://github.com/swc-project/swc/releases/tag/swc_core%40v10.1.0

Why?

To apply #73696 and parallelization improvements.

How?

Closes PACK-3702

ijjk · 2025-01-07T10:33:43Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
buildDuration	38.5s	33.1s	N/A
buildDurationCached	30s	29.3s	N/A
nodeModulesSize	416 MB	416 MB	✓
nextStartRea..uration (ms)	959ms	1s	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
5306-HASH.js gzip	53.3 kB	53.3 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.44 kB	5.44 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	34.1 kB	34.1 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.57 kB	4.57 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
index.html gzip	522 B	521 B	N/A
link.html gzip	538 B	535 B	N/A
withRouter.html gzip	518 B	518 B	✓
Overall change	518 B	518 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	207 kB	207 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
middleware-b..fest.js gzip	671 B	667 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.2 kB	31.2 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	367 kB	367 kB	✓
app-page-exp..prod.js gzip	129 kB	129 kB	✓
app-page-tur..prod.js gzip	142 kB	142 kB	✓
app-page-tur..prod.js gzip	138 kB	138 kB	✓
app-page.run...dev.js gzip	355 kB	355 kB	✓
app-page.run..prod.js gzip	126 kB	126 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.5 kB	27.5 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.46 MB	2.46 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js kdy1/swc-core-10	Change
0.pack gzip	2.09 MB	2.09 MB	⚠️ +2.13 kB
index.pack gzip	75.1 kB	76.1 kB	⚠️ +992 B
Overall change	2.17 MB	2.17 MB	⚠️ +3.12 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: f1b3a4f

kdy1 · 2025-01-07T10:39:05Z

turbopack/crates/turbopack-tests/tests/execution/turbopack/wasm/complex/input/magic.wat

@@ -9,7 +9,7 @@
  (func $set (export "set") (type $t1) (param $p i32)
    (i32.store
      (i32.const 0)
-      (get_local $p)))
+      (local.get $p)))


https://webassembly.github.io/wabt/demo/wat2wasm/

kdy1 · 2025-01-07T10:40:33Z

.github/workflows/build_and_deploy.yml

@@ -239,7 +239,7 @@ jobs:
            build: >-
              set -ex &&
              apt update &&
-              apt install -y pkg-config xz-utils dav1d libdav1d-dev &&
+              apt install -y pkg-config xz-utils dav1d libdav1d-dev clang-static llvm-dev &&


x-ref: swc-project/swc@236986e

kdy1 · 2025-01-07T10:40:37Z

.github/workflows/build_and_deploy.yml

@@ -261,7 +261,7 @@ jobs:
            build: >-
              set -ex &&
              apk update &&
-              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev &&
+              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev clang-static llvm-dev &&


x-ref: swc-project/swc@236986e

kdy1 · 2025-01-07T10:40:41Z

.github/workflows/build_and_deploy.yml

@@ -221,7 +221,7 @@ jobs:
            build: >-
              set -ex &&
              apk update &&
-              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev &&
+              apk add --no-cache libc6-compat pkgconfig dav1d libdav1d dav1d-dev clang-static llvm-dev &&


x-ref: swc-project/swc@236986e

kdy1 · 2025-01-07T10:41:06Z

crates/next-custom-transforms/tests/full/example/output.js

@@ -4,5 +4,5 @@ import r from 'other';
 e(r, 1)[0];
 export var __N_SSG = !0;
 export default function t() {
-    return /*#__PURE__*/ React.createElement("div", null);
+    return React.createElement("div", null);


This is removed because this is the last output.

Can you explain the difference with it being the last output?

swc-project/swc#9674

Flags like __PURE__ will be preserved for non-last ones.

ijjk · 2025-01-07T10:55:18Z

Tests Passed

sokra · 2025-01-07T11:08:27Z

see https://github.com/vercel/next.js/actions/runs/12650052136

aarch64-unknown-linux-gnu fails with:

E: Unable to locate package clang-static

sokra

Build is still failing: https://github.com/vercel/next.js/actions/runs/12665593382/job/35295524225

A different error now...

sokra · 2025-01-08T07:06:54Z

To test it you have to manually trigger this action for your branch: https://github.com/vercel/next.js/actions/workflows/build_and_deploy.yml

kdy1 · 2025-01-08T07:11:21Z

Oops. I thought https://github.com/vercel/next.js/actions/runs/12651768105/job/35253014037?pr=74580 is identical as the build-and-deploy action

- https://webassembly.github.io/wabt/demo/wat2wasm/

…_64-unknown-linux-gnu/sysroot/lib &&

…-gnu/x86_64-unknown-linux-gnu/sysroot/lib &&" This reverts commit 864a3dc.

kdy1 · 2025-01-10T04:15:37Z

The build passes. https://github.com/vercel/next.js/actions/runs/12702855131

kdy1 · 2025-01-10T05:10:57Z

The segfault turned out to be worker_thread thing (of terser-webpack-plugin) and is not a problem for next-swc or direct users.

kdy1 self-assigned this Jan 7, 2025

ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 7, 2025

kdy1 commented Jan 7, 2025

View reviewed changes

kdy1 marked this pull request as ready for review January 7, 2025 13:26

kdy1 requested review from sokra and a team January 7, 2025 13:26

kdy1 enabled auto-merge (squash) January 8, 2025 03:23

sokra requested changes Jan 8, 2025

View reviewed changes

kdy1 marked this pull request as draft January 8, 2025 07:09

auto-merge was automatically disabled January 8, 2025 07:09
Pull request was converted to draft

kdy1 mentioned this pull request Jan 8, 2025

@swc/plugin-formatjs: Plugin invokation fails with pointer out of bounds swc-project/plugins#387

Closed

kdy1 force-pushed the kdy1/swc-core-10 branch from b2ab4b6 to ecf1b88 Compare January 9, 2025 15:04

kdy1 changed the title ~~build: Update swc_core to v10.0.1~~ build: Update swc_core to v10.1.0 Jan 10, 2025

kdy1 mentioned this pull request Jan 10, 2025

build: Make build dependency on zip and xz optional wasmerio/wasmer#5333

Merged

kdy1 added 9 commits January 10, 2025 12:28

Update swc_core to v10.0.1

53f2a0e

cargo lockfile

f6736d9

Fix build

79f4f0d

Fix wasm.

e13889f

- https://webassembly.github.io/wabt/demo/wat2wasm/

Update test refs

c2ead25

chore: Use clang for apt

902cec9

Dep on rustc-hash

bbe8e3d

cargo lockfile

d591261

Use fxhash for emotion

c34d86f

kdy1 added 19 commits January 10, 2025 12:28

export CFLAGS

7c41cc6

\

52d601c

reset CI

a42a85f

\\

ccfbf60

\\

e5ef505

\\ for ()

b0d9248

Remove \\

739d37b

revert install

b54b7e3

include path

301d169

libzstd-dev

ea898b2

lzma-dev

9818a76

autotools-dev && autoconf

0e84414

cp /usr/lib/x86_64-linux-gnu/libz.a /usr/x86_64-unknown-linux-gnu/x86…

1dbd319

…_64-unknown-linux-gnu/sysroot/lib &&

Revert "cp /usr/lib/x86_64-linux-gnu/libz.a /usr/x86_64-unknown-linux…

c5be12d

…-gnu/x86_64-unknown-linux-gnu/sysroot/lib &&" This reverts commit 864a3dc.

Revert

20bd5a2

Update swc_core to v10.1.0

c1682c0

cargo lockfile

de18850

Override

145b8e0

cargo lockfile

32a7ada

kdy1 force-pushed the kdy1/swc-core-10 branch from 95bbbf8 to 32a7ada Compare January 10, 2025 03:29

cargo lockfile

f1b3a4f

kdy1 requested a review from sokra January 10, 2025 04:15

kdy1 marked this pull request as ready for review January 10, 2025 04:18

kdy1 enabled auto-merge (squash) January 10, 2025 05:04

kdy1 requested a review from a team January 10, 2025 14:57

sokra approved these changes Jan 10, 2025

View reviewed changes

kdy1 merged commit da3f782 into canary Jan 10, 2025
147 checks passed

kdy1 deleted the kdy1/swc-core-10 branch January 10, 2025 15:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Update `swc_core` to `v10.1.0` #74580

build: Update `swc_core` to `v10.1.0` #74580

kdy1 commented Jan 7, 2025 •

edited by padmaia

Loading

ijjk commented Jan 7, 2025 •

edited

Loading

kdy1 Jan 7, 2025

kdy1 Jan 7, 2025

kdy1 Jan 7, 2025

kdy1 Jan 7, 2025

kdy1 Jan 7, 2025

timneutkens Jan 10, 2025

kdy1 Jan 10, 2025

ijjk commented Jan 7, 2025 •

edited

Loading

sokra commented Jan 7, 2025

sokra left a comment

sokra commented Jan 8, 2025

kdy1 commented Jan 8, 2025

kdy1 commented Jan 10, 2025

kdy1 commented Jan 10, 2025

build: Update swc_core to v10.1.0 #74580

build: Update swc_core to v10.1.0 #74580

Conversation

kdy1 commented Jan 7, 2025 • edited by padmaia Loading

What?

Why?

How?

ijjk commented Jan 7, 2025 • edited Loading

Stats from current PR

kdy1 Jan 7, 2025

Choose a reason for hiding this comment

kdy1 Jan 7, 2025

Choose a reason for hiding this comment

kdy1 Jan 7, 2025

Choose a reason for hiding this comment

kdy1 Jan 7, 2025

Choose a reason for hiding this comment

kdy1 Jan 7, 2025

Choose a reason for hiding this comment

timneutkens Jan 10, 2025

Choose a reason for hiding this comment

kdy1 Jan 10, 2025

Choose a reason for hiding this comment

ijjk commented Jan 7, 2025 • edited Loading

Tests Passed

sokra commented Jan 7, 2025

sokra left a comment

Choose a reason for hiding this comment

sokra commented Jan 8, 2025

kdy1 commented Jan 8, 2025

kdy1 commented Jan 10, 2025

kdy1 commented Jan 10, 2025

build: Update `swc_core` to `v10.1.0` #74580

build: Update `swc_core` to `v10.1.0` #74580

kdy1 commented Jan 7, 2025 •

edited by padmaia

Loading

ijjk commented Jan 7, 2025 •

edited

Loading

ijjk commented Jan 7, 2025 •

edited

Loading