Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add marker with label #669

Merged
merged 7 commits into from
Oct 16, 2017
Merged

Conversation

tomchentw
Copy link
Owner

@tomchentw tomchentw commented Oct 16, 2017

Description

Full credit goes to #657

Screenshots

screencapture-localhost-6060-1508166340657

Daghan Gunay and others added 7 commits October 16, 2017 23:36
BREAKING CHANGE: MarkerWithLabel comes with its own React Component now

Before:

```js
import { Marker } from "react-google-maps";

<Marker
  position={{ lat: -34.397, lng: 150.644 }}
  labelAnchor={new google.maps.Point(0, 0)}
  labelContent="<div>Hello There!</div>"
  labelStyle={{/* WON'T WORK */}}
/>
```

After:

```js
import MarkerWithLabel from "react-google-maps/lib/components/addons/MarkerWithLabel";

<MarkerWithLabel
  position={{ lat: -34.397, lng: 150.644 }}
  labelAnchor={new google.maps.Point(0, 0)}
  labelStyle={{backgroundColor: "yellow", fontSize: "32px", padding: "16px"}}
>
  <div>Hello There!</div>
</MarkerWithLabel>
```
@tomchentw tomchentw merged commit 99715c0 into master Oct 16, 2017
@tomchentw tomchentw deleted the feature/add-MarkerWithLabel branch October 16, 2017 15:43
@tomchentw
Copy link
Owner Author

Released v9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant