chore(src/components): Add MarkerWithLabel Component #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2017
tomchentw
requested changes
Oct 11, 2017
.editorconfig
Outdated
| @@ -10,7 +10,7 @@ insert_final_newline = true | |||
|
|
|||
| # Matches multiple files with brace expansion notation | |||
| # Set default charset | |||
| [*.{js,py}] | |||
| [*.{js,py,jsx}] | |||
lib/components/Marker.js
Outdated
| @@ -76,7 +76,7 @@ var Marker = (exports.Marker = (function(_React$PureComponent) { | |||
| ) | |||
| ) | |||
|
|
|||
| var GMKlass = _this.props.markerWithLabel || google.maps.Marker | |||
| var GMKlass = google.maps.Marker | |||
src/components/Marker.jsx
Outdated
| @@ -318,7 +288,7 @@ export class Marker extends React.PureComponent { | |||
| */ | |||
| constructor(props, context) { | |||
| super(props, context) | |||
| const GMKlass = this.props.markerWithLabel || google.maps.Marker | |||
| const GMKlass = google.maps.Marker | |||
There was a problem hiding this comment.
Don't commit src/components yet. Should just src/macros
src/macros/Marker.jsx
Outdated
| @@ -77,7 +52,7 @@ export class Marker extends React.PureComponent { | |||
| */ | |||
| constructor(props, context) { | |||
| super(props, context) | |||
| const GMKlass = this.props.markerWithLabel || google.maps.Marker | |||
| const GMKlass = google.maps.Marker | |||
| /* global google */ | ||
| import React from "react" | ||
| import PropTypes from "prop-types" | ||
| import _MarkerWithLabel from "markerwithlabel" |
| super(props, context) | ||
| const markerWithLabel = new _MarkerWithLabel(google.maps) | ||
| const container = document.createElement("div") | ||
| ReactDOM.render(this.props.children, container) |
There was a problem hiding this comment.
Don't render in the constructor method. Please see the corresponding code in InfoBox/InfoWindow
|
I'll look into |
d46
force-pushed
the
master
branch
5 times, most recently
from
ab4f28f to
0f66c25
Compare
|
Released v9.0.0 |
|
@tomchentw Thanks for the MarkerwithLabel feature But I am not able to add infowindow with the marker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented MarkerWithLabel like a new component as @tomchentw said but i get some problems.
MarkerWithLabel wraps the google's Marker object so i decided to fetch prototypes from google document like in Marker macro. In this case i had to use Marker for class name to fetch Marker api.
Naming for Marker made errors like this
I didn't touch jscodeshit side but in this implementation maybe we need to change fetching data with class name scenario.
In the constructor i had to use ReactDOM.render. MarkerWithLabel require string for labelContent.
Also when we send null or empty string to labelContent it cause crash.
I used this in componentDidUpdate shallow compare too. What do you think for this approach?
Waiting your feedback to better implementation.