Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0145] Pull in cel-go to vendor #7245

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[TEP-0145] Pull in cel-go to vendor #7245

merged 1 commit into from
Oct 19, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Oct 19, 2023 •
edited
Loading

Changes

This is the first step of TEP-0145 tracking issue is #7244, same as tekton/triggers, we will use cel-go as the library to evaluate the CEL expression.

This PR pulls the dependency first to avoid rebasing all the time and help reviewers to better review the following feature PRs by reducing noises, no functional change in this PR

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 19, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2023
@Yongxuanzhang Yongxuanzhang added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 19, 2023
@Yongxuanzhang
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@Yongxuanzhang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yongxuanzhang Yongxuanzhang mentioned this pull request Oct 19, 2023
Closed
5 tasks
QuanZhang-William
QuanZhang-William reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@QuanZhang-William QuanZhang-William left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/apis/pipeline/v1/when_validation.go Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@jerop
Copy link
Member

jerop commented Oct 19, 2023

/test pull-tekton-pipeline-alpha-integration-tests

@Yongxuanzhang
[TEP-0145] Pull in cel-go to vendor
cb851ae 
This is the first step of TEP-0145, same as tekton/triggers, we will use
cel-go as the library to evaluate the CEL expression. Pull the
dependency first to avoid rebasing all the time.

Signed-off-by: Yongxuan Zhang [email protected]
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@QuanZhang-William
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@tekton-robot tekton-robot merged commit a2cf8d0 into tektoncd:main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

@QuanZhang-William QuanZhang-William Awaiting requested review from QuanZhang-William

Assignees

@QuanZhang-William QuanZhang-William

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yongxuanzhang @tekton-robot @jerop @QuanZhang-William