Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile windows error #3119

Merged
merged 1 commit into from
Dec 27, 2021
Merged

fix compile windows error #3119

merged 1 commit into from
Dec 27, 2021

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Dec 24, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #3119 (ea2c63a) into master (a2ca1c3) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
+ Coverage   32.88%   32.98%   +0.11%     
==========================================
  Files         518      518              
  Lines       46774    46774              
  Branches    21278    21278              
==========================================
+ Hits        15377    15425      +48     
+ Misses      17078    16890     -188     
- Partials    14319    14459     +140     
Flag Coverage Δ
unittests 32.98% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
consensus/src/consensus.rs 42.86% <0.00%> (-15.87%) ⬇️
vm/natives/src/token.rs 20.00% <0.00%> (-13.33%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-12.50%) ⬇️
network/src/worker.rs 38.71% <0.00%> (-11.29%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-10.71%) ⬇️
vm/types/src/on_chain_config/mod.rs 41.10% <0.00%> (-5.47%) ⬇️
cmd/starcoin/src/cli_state.rs 44.74% <0.00%> (-5.26%) ⬇️
executor/src/executor.rs 50.00% <0.00%> (-4.16%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ca1c3...ea2c63a. Read the comment docs.

@jolestar jolestar requested a review from sanlee42 December 25, 2021 00:23
@sanlee42 sanlee42 merged commit d8121fe into master Dec 27, 2021
@sanlee42 sanlee42 deleted the fix_compile_windows_error branch December 27, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants