Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Update move dependency for Windows support #3388

Merged
merged 1 commit into from
May 7, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented May 7, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Pickup move-language/move#90 for support Windows

What is the current behavior?

Issue Number: #3130

What is the new behavior?

Other information

@jolestar jolestar requested review from nanne007 and xudon9 May 7, 2022 02:21
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #3388 (762c4c4) into master (dfd3270) will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
- Coverage   32.36%   31.88%   -0.47%     
==========================================
  Files         500      500              
  Lines       46815    46815              
  Branches    21314    21295      -19     
==========================================
- Hits        15145    14924     -221     
- Misses      17630    17708      +78     
- Partials    14040    14183     +143     
Flag Coverage Δ
unittests 31.88% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/types/src/on_chain_config/mod.rs 42.47% <0.00%> (-13.69%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-13.04%) ⬇️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
commons/accumulator/src/tree.rs 54.19% <0.00%> (-11.82%) ⬇️
chain/src/verifier/mod.rs 36.72% <0.00%> (-11.71%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
chain/open-block/src/lib.rs 31.79% <0.00%> (-11.25%) ⬇️
executor/src/block_executor.rs 22.23% <0.00%> (-11.11%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 39.85% <0.00%> (-9.96%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd3270...762c4c4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 7, 2022

Benchmark for 95dd2b8

Click to view benchmark
Test Base PR %
accumulator_append 601.7±14.14µs 588.1±12.76µs -2.26%
block_apply/block_apply_10 264.8±1.87ms 264.4±1.77ms -0.15%
block_apply/block_apply_1000 27.1±0.04s 27.2±0.02s +0.37%
get_with_proof/db_store 37.1±0.38µs 36.2±0.20µs -2.43%
get_with_proof/mem_store 31.7±0.34µs 31.2±0.39µs -1.58%
put_and_commit/db_store/1 96.6±5.01µs 96.4±5.11µs -0.21%
put_and_commit/db_store/10 865.7±40.45µs 860.8±41.92µs -0.57%
put_and_commit/db_store/100 7.4±0.26ms 7.3±0.29ms -1.35%
put_and_commit/db_store/5 446.5±36.96µs 438.1±21.94µs -1.88%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 62.6±5.93µs 61.7±5.86µs -1.44%
put_and_commit/mem_store/10 578.8±48.51µs 573.8±49.66µs -0.86%
put_and_commit/mem_store/100 5.6±0.35ms 5.7±0.85ms +1.79%
put_and_commit/mem_store/5 292.3±25.39µs 290.0±25.38µs -0.79%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.13ms 3.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 38.3±0.51ms 38.3±0.71ms 0.00%
query_block/query_block_in(10)_times(10000) 386.2±9.13ms 390.5±9.54ms +1.11%
query_block/query_block_in(1000)_times(100) 942.7±19.68µs 955.8±5.95µs +1.39%
query_block/query_block_in(1000)_times(1000) 9.4±0.11ms 9.7±0.19ms +3.19%
query_block/query_block_in(1000)_times(10000) 93.6±0.46ms 95.9±0.59ms +2.46%
storage_transaction 1077.3±302.14µs 1087.3±367.18µs +0.93%
vm/transaction_execution/1 313.1±1.82ms 313.3±2.90ms +0.06%
vm/transaction_execution/10 99.0±0.59ms 98.3±0.34ms -0.71%
vm/transaction_execution/20 91.9±0.14ms 91.8±0.63ms -0.11%
vm/transaction_execution/5 120.7±0.65ms 120.0±0.34ms -0.58%
vm/transaction_execution/50 107.8±3.52ms 105.8±0.34ms -1.86%

@xudon9 xudon9 enabled auto-merge (squash) May 7, 2022 05:17
Copy link
Contributor

@xudon9 xudon9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move dependency update

@xudon9 xudon9 merged commit 93941ce into master May 7, 2022
@xudon9 xudon9 deleted the update_move_dep_for_windows_support branch May 7, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants