Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the esbuild dependencies #98

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: update the esbuild dependencies #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bundler/esbuild_bundler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as esbuild from "npm:esbuild@0.23.1";
import { denoPlugins } from "jsr:@luca/esbuild-deno-loader@0.10.3";
import * as esbuild from "npm:esbuild@0.24.2";
import { denoPlugins } from "jsr:@luca/esbuild-deno-loader@0.11.1";

type EsbuildBundleOptions = {
/** The path to the file being bundled */
Expand All @@ -17,7 +17,7 @@
const result = await esbuild.build({
entryPoints: [options.entrypoint],
platform: "browser",
// TODO: the versions should come from the user defined input

Check warning on line 20 in src/bundler/esbuild_bundler.ts

View workflow job for this annotation

GitHub Actions / Health Score

src/bundler/esbuild_bundler.ts#L20 

Problematic comment ("TODO") identified
target: "deno1",
format: "esm", // esm format stands for "ECMAScript module"
bundle: true, // inline any imported dependencies into the file itself
Expand Down
Loading