Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the esbuild dependencies #98

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR aims to improve the bundle experience of the SDK by updating the esbuild-deno-loader version

You can tests this out by overriding the "build" in the slack.json file of a peoject

{
  "hooks": {
    "get-hooks": "deno run -q --allow-read --allow-net https://deno.land/x/[email protected]/mod.ts",
    "build": "deno run -q --config=deno.jsonc --allow-read --allow-write --allow-net --allow-run --allow-env --allow-sys=osRelease https://raw.githubusercontent.com/slackapi/deno-slack-hooks/refs/heads/update-dependencies/src/build.ts"
  }
}

Requirements (place an x in each [ ])

@WilliamBergamin WilliamBergamin added the dependencies Pull requests that update a dependency file label Jan 6, 2025
@WilliamBergamin WilliamBergamin self-assigned this Jan 6, 2025
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner January 6, 2025 22:12
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.31%. Comparing base (0916465) to head (6849c77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   78.31%   78.31%           
=======================================
  Files          16       16           
  Lines         876      876           
  Branches      130      130           
=======================================
  Hits          686      686           
  Misses        189      189           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and this is awesome! These releases seem to have done something magic, since npm:slackify-markdown from #89 works with these changes! 🪄 ✨

Wanted to note that support for some older systems is removed with the esbuild release, but I don't believe that requires major changes for us - let me know if you think otherwise though 🤔

@WilliamBergamin WilliamBergamin merged commit 1e63b74 into main Jan 7, 2025
6 checks passed
@WilliamBergamin WilliamBergamin deleted the update-dependencies branch January 7, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants