Case annotations after contracted prepositions

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-iOS' Code of Conduct

Description

Scribe shows case annotations after German prepositions like “in”, “für” and “zu”. As of now it does now show them on cases where a combined preposition has been typed like “zu” + “der” = “zur”. This issue would add a condition to show the appropriate preposition annotations after such words. This issue could also be done in Python in Scribe-Data as well in a way that would simply generate a JSON file with the appropriate data to also include these :)

Contribution

Happy to work on this or support someone who has interest :)

[andrewtavis]

The person has potentially chosen the right option and doesn't need the annotation, but the behavior of showing the annotations after prepositions should be maintained.

[ArslanYM]

@andrewtavis Can i work on this?

[andrewtavis]

Hey @ArslanYM! Thanks for your interest both here and in #278 😊 You’d be welcome to work on this. Let’s chat quickly on what we think is the best way to do this. Should we add entries to the prepositions dictionary on the Swift side, or should this be handled on data preparation? I’m fine with both, and I guess doing the former would be easier and shouldn’t be frowned upon as the data output is sound: “zur” in itself isn’t a preposition.

If this sounds good, then I think the change would go into loadKeys in the main view controller — first checking if the keyboard is German, and then in the initial keyboard load step we’d add the entries to prepositions :)

Lemme know what you think! Assigning you now 😊

[andrewtavis]

This line right here is the conditional that checks if it's the first time the keyboard is loading. Within there is generally where I put the logic that extends the dictionaries and such. You can see in the line below that's in there how we'd add entries:

nouns["Scribe"] = [
        "plural": "Scribes",
        "form": ""
      ]

We'd then generally just need to define which preposition combinations need to be included, check for the German keyboard, and add them in the above way :)

[ArslanYM]

@andrewtavis Sorry for bothering. I don't think i can work on this.

[andrewtavis]

No bother! Happy to help you figure it out of you have interest, but no stress if not :)

[andrewtavis]

Closed in 97c0afb 🚀

[andrewtavis]

Thanks again for chatting with me about this, @ArslanYM! Was really helpful to explain it and plan it out for myself 😊 If you're looking for a good first issue, then #280 would be a great one to jump in to :)

Have a nice weekend!

[ArslanYM]

Sure thing. Thankyou for being a great mentor.

[andrewtavis]

My pleasure! Thanks again for your interest 😊 Let me know in #280 if you want to be assigned, and again very happy to explain or discuss further :D