Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duble dash inserts em dash in proxy #280

Closed
2 tasks done
andrewtavis opened this issue Apr 7, 2023 · 4 comments
Closed
2 tasks done

Duble dash inserts em dash in proxy #280

andrewtavis opened this issue Apr 7, 2023 · 4 comments
Assignees
Labels
-next release- Included in the next release feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue is a simple addition to Scribe that allows for an em dash to be inserted if the user does two dashes - in a row. This is typical keyboard behavior, and also allows for a easier access to that character. I think putting a conditional for case "-": after this part in the function that determines key functionality would be a good way to implement this. We'd need to check what the last character in the text proxy is, and afterwards we could do the replacement if there are two in a row 😊

Contribution

Happy to work on this myself or help someone who has interest!

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 7, 2023
@andrewtavis andrewtavis changed the title Duble dash creates em dash Duble dash inserts em dash in proxy Apr 7, 2023
@andrewtavis
Copy link
Member Author

Something to consider is whether we need a menu item for this once #16 is finished 🤔

@andrewtavis andrewtavis added the -next release- Included in the next release label Apr 7, 2023
@jocoand
Copy link
Contributor

jocoand commented Apr 8, 2023

Hello, is the issue still open? I am interested try solve the issue

@andrewtavis
Copy link
Member Author

Hi @jocoand! Thanks for your interest in Scribe 😊 Issue is still open, and I’m happy to get some help with it. I’ll check #285 sometime today :)

@andrewtavis
Copy link
Member Author

Thanks for your work on this, @jocoand! Appreciate the help, especially when I'm trying to do a release soonish 😊 Let me know if you'd like suggestions of what other issues you could work on. Would be happy to collaborate again :)

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants