Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Future proof release against uproot4 API changes #930

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

matthewfeickert
Copy link
Member

Description

As @jpivarski mentioned that uproot4 is going to have some API changes from the uproot v3 releases, require that the version of uproot that is included in the releases until uproot4 is released for broad use is using the uproot v3 API.

Once uproot4 is released and stable this can get changed to using

'xmlio': ['uproot~=4.0']

to ensure that all future releases of pyhf get the uproot4 API.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Ensure that the next release series of pyhf isn't broken in the future by API changes in uproot4

* Ensure that the next release series of pyhf isn't broken in the future
by API changes in uproot4
@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Jul 8, 2020
@matthewfeickert matthewfeickert self-assigned this Jul 8, 2020
@matthewfeickert matthewfeickert added the build Changes that affect the build system or external dependencies label Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #930 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files          56       56           
  Lines        3191     3191           
  Branches      438      438           
=======================================
  Hits         3073     3073           
  Misses         75       75           
  Partials       43       43           
Flag Coverage Δ
#unittests 96.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79984be...e331d3a. Read the comment docs.

setup.py Show resolved Hide resolved
@kratsg kratsg merged commit c898e05 into master Jul 9, 2020
@kratsg kratsg deleted the chore/futureproof-against-uproot4 branch July 9, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies chore Other changes that don't modify src or test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants