-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Begin move to uproot4 #1002
Conversation
296368f
to
a94410b
Compare
d4f6bfd
to
a2ac9e8
Compare
a2ac9e8
to
e594b04
Compare
492f872
to
9c1e7d8
Compare
9c1e7d8
to
9cfe2b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 97.46% 97.47%
=======================================
Files 63 63
Lines 3713 3716 +3
Branches 524 525 +1
=======================================
+ Hits 3619 3622 +3
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments inline!
One thing, can you use uproot4's sphinx referencing? intersphinx_mapping = {
'uproot': ('https://uproot.readthedocs.io/en/latest/', None),
} which should work pretty well in our case (unless we need to point to a specific version). |
Used when the exception to catch is of the form “except A or B:”. If intending to catch multiple, rewrite as “except (A, B):” c.f. https://pycodequ.al/docs/pylint-messages/w0711-binary-op-exception.html
bfe4e5e
to
538265a
Compare
Description
Following PR #930 and the release of
v0.5.0
, this PR now moves to adoptinguproot4
and its API.As of
uproot4
v4.0.0
uproot4
does not support the ability to write to ROOT files, souproot3
must still be retained to write to ROOT. This is the only remaining requirement foruproot3
and so the move to theuproot4
API can begin now.As
uproot4
is also added to the HEAD of dependnecies workflow, the pattern ofis used instead of
as installing
uproot4
from GitHub installs under theuproot
namespace. So to test the HEAD ofuproot4
, theuproot
namespace must be used now instead of waiting to dropuproot3
.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: