-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculator API #709
feat: calculator API #709
Conversation
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 94.86% 93.94% -0.92%
==========================================
Files 52 54 +2
Lines 2765 2826 +61
Branches 393 395 +2
==========================================
+ Hits 2623 2655 +32
- Misses 97 125 +28
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7a3b145
to
9f1d872
Compare
rebased to #712 |
#1258 adds in the last piece from this PR so I will close this in favor of following up there. |
Description
Introduces the "calculator API" in order to allow to run inference in various modes (toybased, asymptotics, etc).
This might be quite a big PR, we can consider splitting it up into various small PRs and rebasing along the way.
Demo notebook:
https://github.com/scikit-hep/pyhf/blob/calculator_api/docs/examples/notebooks/UsingCalculators.ipynb
Sub-changes:
qmu
to return scalar instead of size-1-tensor feat: change qmu API and remove test_stat return #712Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: