Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculator API #709

Closed
wants to merge 11 commits into from
Closed

feat: calculator API #709

wants to merge 11 commits into from

Conversation

lukasheinrich
Copy link
Contributor

@lukasheinrich lukasheinrich commented Dec 27, 2019

Description

Introduces the "calculator API" in order to allow to run inference in various modes (toybased, asymptotics, etc).

This might be quite a big PR, we can consider splitting it up into various small PRs and rebasing along the way.

Demo notebook:

https://github.com/scikit-hep/pyhf/blob/calculator_api/docs/examples/notebooks/UsingCalculators.ipynb

Sub-changes:

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

Merging #709 into master will decrease coverage by 0.91%.
The diff coverage is 72.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   94.86%   93.94%   -0.92%     
==========================================
  Files          52       54       +2     
  Lines        2765     2826      +61     
  Branches      393      395       +2     
==========================================
+ Hits         2623     2655      +32     
- Misses         97      125      +28     
- Partials       45       46       +1     
Flag Coverage Δ
#unittests 93.94% <72.38%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/infer/toybased.py 26.31% <26.31%> (ø)
src/pyhf/infer/__init__.py 97.05% <94.44%> (-2.95%) ⬇️
src/pyhf/infer/asymptotics.py 100.00% <100.00%> (ø)
src/pyhf/infer/test_statistics.py 100.00% <100.00%> (ø)
src/pyhf/infer/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c7e72...9f1d872. Read the comment docs.

@lukasheinrich
Copy link
Contributor Author

rebased to #712

@kratsg
Copy link
Contributor

kratsg commented Jan 14, 2021

#1258 adds in the last piece from this PR so I will close this in favor of following up there.

@kratsg kratsg closed this Jan 14, 2021
@matthewfeickert matthewfeickert deleted the calculator_api branch February 24, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants