-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add learn notebook on using calculators #1258
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 63 63
Lines 3716 3716
Branches 525 525
=======================================
Hits 3622 3622
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1562e5c
to
a517085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kratsg. Just a quick suggestion from me and then I'll review later today when I'm finished with current work.
Co-authored-by: Matthew Feickert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kratsg I made some small formatting changes (tried to make it easy to revert any that you didn't like) and added this notebook to the notebook tests, but all LGTM! 👍
Description
This is the last thing from #709 that we don't have in
pyhf
by now.Render: https://pyhf.readthedocs.io/en/docs-usingcalculators/examples/notebooks/learn/UsingCalculators.html
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: