Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stricter schema definitions for histosys and normsys #1388

Merged
merged 4 commits into from
Apr 5, 2021

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Mar 31, 2021

Pull Request Description

Resolves #1387. Histosys and Normsys should be stricter about not allowing additional properties in the data object in the schema.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Teach the schema to not allow additional properties for histosys and normsys
* Be more explicit about the patchset/jsonpatch metadata information (that we do allow additionalProperties)
* Add tests to check that additionalProperties for for histosys and normsys result in an invalid spec

@kratsg kratsg added fix A bug fix schema and spec JSON schema tests pytest labels Mar 31, 2021
@kratsg kratsg self-assigned this Mar 31, 2021
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kratsg.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1388 (2d51555) into master (9e30e6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          63       63           
  Lines        3808     3808           
  Branches      538      538           
=======================================
  Hits         3714     3714           
  Misses         55       55           
  Partials       39       39           
Flag Coverage Δ
contrib 24.18% <ø> (ø)
unittests 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e30e6e...2d51555. Read the comment docs.

@matthewfeickert matthewfeickert merged commit cbf8d03 into master Apr 5, 2021
@matthewfeickert matthewfeickert deleted the fix/schema branch April 5, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix schema and spec JSON schema tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normsys/data and histosys/data allow additional properties, is this intended?
2 participants