Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normsys/data and histosys/data allow additional properties, is this intended? #1387

Closed
lhenkelm opened this issue Mar 30, 2021 · 0 comments · Fixed by #1388
Closed

normsys/data and histosys/data allow additional properties, is this intended? #1387

lhenkelm opened this issue Mar 30, 2021 · 0 comments · Fixed by #1388
Assignees
@kratsg
Labels
schema and spec JSON schema

Comments

@lhenkelm
Copy link
Contributor

In the current schema definitions, the data properties in normsys and histosys
are of type object, but they do not specify the additionalProperties property. So the jsonschema default is used, meaning any and all additional properties are valid.

Is this intended? All other defintions (outside the patchset schemata) "close" the schema by setting "additionalProperties": false, and that seems to me to match the expectation from HF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratsg kratsg

Labels
schema and spec JSON schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Stricter schema definitions for histosys and normsys scikit-hep/pyhf
2 participants
@kratsg @lhenkelm