Logging improvements #260
Logging improvements #260
Conversation
|
Hi @Ape, I agree that Luciferin defaults to a log level that is quite verbose but disabling logging entirely is not a good option in my opinion. I'll change the default log level to ERROR In this way no log file will be created if there are no errors, and the log file will be in the $XDG_DATA_HOME folder. I leave this PR opened just to remember that it needs additional work. PS: As I said the the feature request I already have some methods that can move the files to another path without breaking existing installation, so I can continue it :) |
I think the current log level is good. I just disagree with the log location. The current logging to stdout is good and I'd definitely leave it at INFO level. If you move the log file to $XDG_DATA_HOME, then maybe it's better to leave that at INFO level, too. Anyway, I will remove the second commit here, so we can get the first one merged. |
|
Also, note that |
yes I used XDG_CONFIG_HOME :) |
- ***Breaking changes***: requires `Firefly Luciferin` firmware (v2.19.3). - The priority of UDP packets in wireless mode has been increased to signal to the router that Luciferin traffic requires lower latency than standard packets. - If the microcontroller is temporarily disconnected from the WiFi network, Firefly Luciferin is now able to reconnect much faster without restarting the screen capture. - Added a 'bottom' capture option for [satellites](https://github.com/sblantipodi/firefly_luciferin/wiki/Surround-lighting-with-satellites) when the LEDs are configured to use a bottom gap. - The [save state](https://github.com/sblantipodi/firefly_luciferin/wiki/Remote-Access#luciferin-web-interface) has been restructured. Auto-save has been disabled to prevent wear on the microcontroller's memory. Closes [#249](sblantipodi/firefly_luciferin#249). - Arch Linux package. Note: AUR package is built from the official sources but it's currently maintained by @Ape. Closes [#246](sblantipodi/firefly_luciferin#246). Thanks @Ape for this. - Libasound2t64 dependency prevents correct installation on some Linux distros. Closes [#253](sblantipodi/firefly_luciferin#253). - Properly handle expired restore token on Wayland. Closes [#259](sblantipodi/firefly_luciferin#259). Thanks @Ape for the PR. - Logging improvements. Closes [#260](sblantipodi/firefly_luciferin#260). Thanks @Ape for the PR. - Proper config path on Linux. Config file and logs has been moved in XDG_CONFIG_HOME (~/.config/FireflyLuciferin). Old config files will be automatically moved to the new path. Closes [#261](sblantipodi/firefly_luciferin#261). - The snap version was crashing at startup when there were temporary files created by other instances of Firefly Luciferin on the system. Fixed.
- ***Breaking changes***: requires `Glow Worm Luciferin` firmware (v5.18.2). - The priority of UDP packets in wireless mode has been increased to signal to the router that Luciferin traffic requires lower latency than standard packets. - If the microcontroller is temporarily disconnected from the WiFi network, Firefly Luciferin is now able to reconnect much faster without restarting the screen capture. - Added a 'bottom' capture option for [satellites](https://github.com/sblantipodi/firefly_luciferin/wiki/Surround-lighting-with-satellites) when the LEDs are configured to use a bottom gap. - The [save state](https://github.com/sblantipodi/firefly_luciferin/wiki/Remote-Access#luciferin-web-interface) has been restructured. Auto-save has been disabled to prevent wear on the microcontroller's memory. Closes [#249](#249). - Arch Linux package. Note: AUR package is built from the official sources but it's currently maintained by @Ape. Closes [#246](#246). Thanks @Ape for this. - Libasound2t64 dependency prevents correct installation on some Linux distros. Closes [#253](#253). - Properly handle expired restore token on Wayland. Closes [#259](#259). Thanks @Ape for the PR. - Logging improvements. Closes [#260](#260). Thanks @Ape for the PR. - Proper config path on Linux. Config file and logs has been moved in XDG_CONFIG_HOME (~/.config/FireflyLuciferin). Old config files will be automatically moved to the new path. Closes [#261](#261). - The snap version was crashing at startup when there were temporary files created by other instances of Firefly Luciferin on the system. Fixed.
The first commit disables a huge number of completely useless logging messages about the logging library itself.
The second commit is a bit opionated, but I really don't want this application to log to a file by default. At the very least the log path should be something more appropriate (e.g. $XDG_DATA_HOME).