Properly handle expired restore token on Wayland #259
Conversation
The previous version just gets crashes on an exception from invalid restore token and doesn't request a new valid one. This version catches the exception and starts the screen cast with a new token. I'm not sure what the purpose of the 200 ms sleep is, so I left it similar to the previous version.
|
Actually, this might be nicer if the permission request pop-up wasn't shown in the case of rerequesting the permissions since the user has already seen the pop-up earlier when he got the previous, now expired, restore token. |
|
thank you Ape I appreciate it.
I agree on this, I added that popup just because Wayland I found no other way to tell the user which screen is requesting the permission on multi monitor setup. I'll merge it and release this fix asap. Thanks! |
So by that reasoning we want to show the pop-up when requesting the permissions again since it might be for a different screen. Could this pop-up be completely disabled when there is just a single monitor? |
correct
yes, I'll add an if to the thanks for your help @Ape much appreciated. |
- ***Breaking changes***: requires `Firefly Luciferin` firmware (v2.19.3). - The priority of UDP packets in wireless mode has been increased to signal to the router that Luciferin traffic requires lower latency than standard packets. - If the microcontroller is temporarily disconnected from the WiFi network, Firefly Luciferin is now able to reconnect much faster without restarting the screen capture. - Added a 'bottom' capture option for [satellites](https://github.com/sblantipodi/firefly_luciferin/wiki/Surround-lighting-with-satellites) when the LEDs are configured to use a bottom gap. - The [save state](https://github.com/sblantipodi/firefly_luciferin/wiki/Remote-Access#luciferin-web-interface) has been restructured. Auto-save has been disabled to prevent wear on the microcontroller's memory. Closes [#249](sblantipodi/firefly_luciferin#249). - Arch Linux package. Note: AUR package is built from the official sources but it's currently maintained by @Ape. Closes [#246](sblantipodi/firefly_luciferin#246). Thanks @Ape for this. - Libasound2t64 dependency prevents correct installation on some Linux distros. Closes [#253](sblantipodi/firefly_luciferin#253). - Properly handle expired restore token on Wayland. Closes [#259](sblantipodi/firefly_luciferin#259). Thanks @Ape for the PR. - Logging improvements. Closes [#260](sblantipodi/firefly_luciferin#260). Thanks @Ape for the PR. - Proper config path on Linux. Config file and logs has been moved in XDG_CONFIG_HOME (~/.config/FireflyLuciferin). Old config files will be automatically moved to the new path. Closes [#261](sblantipodi/firefly_luciferin#261). - The snap version was crashing at startup when there were temporary files created by other instances of Firefly Luciferin on the system. Fixed.
- ***Breaking changes***: requires `Glow Worm Luciferin` firmware (v5.18.2). - The priority of UDP packets in wireless mode has been increased to signal to the router that Luciferin traffic requires lower latency than standard packets. - If the microcontroller is temporarily disconnected from the WiFi network, Firefly Luciferin is now able to reconnect much faster without restarting the screen capture. - Added a 'bottom' capture option for [satellites](https://github.com/sblantipodi/firefly_luciferin/wiki/Surround-lighting-with-satellites) when the LEDs are configured to use a bottom gap. - The [save state](https://github.com/sblantipodi/firefly_luciferin/wiki/Remote-Access#luciferin-web-interface) has been restructured. Auto-save has been disabled to prevent wear on the microcontroller's memory. Closes [#249](#249). - Arch Linux package. Note: AUR package is built from the official sources but it's currently maintained by @Ape. Closes [#246](#246). Thanks @Ape for this. - Libasound2t64 dependency prevents correct installation on some Linux distros. Closes [#253](#253). - Properly handle expired restore token on Wayland. Closes [#259](#259). Thanks @Ape for the PR. - Logging improvements. Closes [#260](#260). Thanks @Ape for the PR. - Proper config path on Linux. Config file and logs has been moved in XDG_CONFIG_HOME (~/.config/FireflyLuciferin). Old config files will be automatically moved to the new path. Closes [#261](#261). - The snap version was crashing at startup when there were temporary files created by other instances of Firefly Luciferin on the system. Fixed.
The previous version just gets crashes on an exception from invalid restore token and doesn't request a new valid one.
This version catches the exception and starts the screen cast with a new token.
I'm not sure what the purpose of the 200 ms sleep is, so I left it similar to the previous version.