Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add smithy-typescript to aws-sdk-js monorepo #33517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

feat(presets): add smithy-typescript to aws-sdk-js monorepo #33517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/data/monorepo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@
"aws-sdk-client-mock": "https://github.com/m-radzikowski/aws-sdk-client-mock",
"aws-sdk-go": "https://github.com/aws/aws-sdk-go",
"aws-sdk-go-v2": "https://github.com/aws/aws-sdk-go-v2",
"aws-sdk-js-v3": "https://github.com/aws/aws-sdk-js-v3",
"aws-sdk-js-v3": [
"https://github.com/aws/aws-sdk-js-v3",
"https://github.com/smithy-lang/smithy-typescript"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the suggested approach?

I followed the same strategy as with aws-sdk-rust monorepo:

    "aws-sdk-rust": [
      "https://github.com/smithy-lang/smithy-rs",
      "https://github.com/awslabs/smithy-rs",
      "https://github.com/awslabs/aws-sdk-rust"
    ],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that was right either. I'll need to look through the history here. These don't seem to be monorepos, just related packages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should check all our monorepos and validate if they share same version or absolutely need to be grouped. we should remove all which don't share same version and don't need to be merged together.

],
"aws-sdk-net": "https://github.com/aws/aws-sdk-net",
"aws-sdk-rust": [
"https://github.com/smithy-lang/smithy-rs",
Expand Down
Loading